feat: add TL FIPS e2e #7770
feat: add TL FIPS e2e #7770
Conversation
mxj220
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end testing support for TrustedLaunch-enabled FIPS Ubuntu 22.04 Gen2 VHD. The changes introduce a new distro constant and corresponding E2E test configuration to validate that nodes using the TrustedLaunch FIPS VHD can be properly bootstrapped with the required security features.
Changes:
- Added new distro constant for TrustedLaunch FIPS Ubuntu 22.04 Gen2
- Created E2E test for TrustedLaunch FIPS functionality
- Added VHD configuration for the new TrustedLaunch FIPS image
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/agent/datamodel/types.go | Defines new distro constant for TrustedLaunch FIPS Ubuntu 22.04 Gen2 |
| e2e/scenario_test.go | Implements E2E test validating TrustedLaunch FIPS VHD bootstrapping |
| e2e/config/vhd.go | Configures VHD image metadata for TrustedLaunch FIPS testing |
|
|
||
| func Test_Ubuntu2204Gen2FIPSTL(t *testing.T) { | ||
| RunScenario(t, &Scenario{ | ||
| Description: "Tests that a node using the Ubuntu 2204 FIPS Gen2 VHD can be properly bootstrapped", |
There was a problem hiding this comment.
The description incorrectly states 'Ubuntu 2204 FIPS Gen2 VHD' but should specify 'Ubuntu 2204 FIPS TrustedLaunch Gen2 VHD' to accurately reflect that this test is specifically for the TrustedLaunch variant.
| Description: "Tests that a node using the Ubuntu 2204 FIPS Gen2 VHD can be properly bootstrapped", | |
| Description: "Tests that a node using the Ubuntu 2204 FIPS TrustedLaunch Gen2 VHD can be properly bootstrapped", |
| Description: "Tests that a node using the Ubuntu 2204 FIPS Gen2 VHD can be properly bootstrapped", | ||
| Config: Config{ | ||
| Cluster: ClusterKubenet, | ||
| VHD: config.VHDUbuntu2204Gen2FIPSContainerd, |
There was a problem hiding this comment.
The VHD configuration references 'VHDUbuntu2204Gen2FIPSContainerd' but should reference 'VHDUbuntu2204Gen2FIPSTLContainerd' to use the TrustedLaunch FIPS VHD that was defined in e2e/config/vhd.go.
| VHD: config.VHDUbuntu2204Gen2FIPSContainerd, | |
| VHD: config.VHDUbuntu2204Gen2FIPSTLContainerd, |
| BootstrapConfigMutator: func(nbc *datamodel.NodeBootstrappingConfiguration) { | ||
| }, |
There was a problem hiding this comment.
Empty function body. If no bootstrap configuration mutations are needed, consider removing this field entirely or adding a comment explaining why it's intentionally empty.
What this PR does / why we need it:
Adds E2E for TrustedLaunch FIPS 22.04 VHD
Which issue(s) this PR fixes:
Fixes #