feat: provide configurable cse timeout in seconds #7766
+200
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesomenix
requested review from
AbelHu,
Devinwong,
YaoC,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright,
yewmsft and
zachary-bailey
as code owners
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable CSE (Custom Script Extension) timeout feature to allow users to override the default 15-minute timeout. This can be useful for debugging slow CSE scripts or handling scenarios that require longer execution times.
Changes:
- Added
CSETimeoutInMinutesconfiguration field with validation (max 360 minutes/6 hours) - Updated shell scripts to use the configurable timeout instead of hardcoded 15m
- Added protobuf field and parser logic to support the new configuration
Reviewed changes
Copilot reviewed 74 out of 134 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/agent/datamodel/types.go | Added CSETimeoutInMinutes field and GetCSETimeout() validation method |
| pkg/agent/datamodel/const.go | Added CSE timeout constants (default 15m, max 360m) |
| pkg/agent/baker.go | Added GetCSETimeout function to template function map |
| parts/linux/cloud-init/artifacts/cse_start.sh | Changed hardcoded 15m timeout to $CSE_TIMEOUT variable |
| parts/linux/cloud-init/artifacts/cse_cmd.sh | Added CSE_TIMEOUT variable from template |
| aks-node-controller/proto/aksnodeconfig/v1/config.proto | Added cse_timeout_in_minutes protobuf field |
| aks-node-controller/parser/parser.go | Added CSE_TIMEOUT to environment variable map |
| aks-node-controller/parser/helper.go | Added getCSETimeout() helper function with validation |
| aks-node-controller/Makefile | Updated to use linux/amd64 platform and changed branch reference |
| testdata/* | Updated binary test data files to reflect the new CSE timeout configuration |
awesomenix
force-pushed
the
add-copilot-steps
branch
from
a55136d to
6961bfa
Compare
awesomenix
force-pushed
the
add-copilot-steps
branch
from
6961bfa to
105904e
Compare
r2k1
reviewed
Jan 31, 2026
awesomenix
force-pushed
the
add-copilot-steps
branch
from
105904e to
b144e0a
Compare
awesomenix
changed the title
r2k1
reviewed
Feb 3, 2026
awesomenix
force-pushed
the
add-copilot-steps
branch
from
b144e0a to
7d01661
Compare
r2k1
reviewed
Feb 3, 2026
r2k1
reviewed
Feb 3, 2026
r2k1
reviewed
Feb 3, 2026
r2k1
reviewed
Feb 3, 2026
awesomenix
force-pushed
the
add-copilot-steps
branch
from
7d01661 to
95d9480
Compare
Co-authored-by: Copilot <[email protected]>
| if cseTimeout <= 0 || cseTimeout > MaxCSETimeout { | ||
| cseTimeout = DefaultCSETimeout | ||
| } | ||
| return fmt.Sprintf("%d", cseTimeout) |
There was a problem hiding this comment.
The function should append 's' (seconds suffix) to the returned string for proper timeout command usage. The timeout command requires a duration with a unit suffix (e.g., "900s" for 900 seconds).
Suggested change
| return fmt.Sprintf("%d", cseTimeout) | |
| return fmt.Sprintf("%ds", cseTimeout) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sometimes this can be useful in debugging why certain CSE scripts are taking a long time, make this configurable through RP or external components
Which issue(s) this PR fixes:
Fixes #