-
Notifications
You must be signed in to change notification settings - Fork 245
chore: Update Windows 2025 version to use specific build number 26100 #6560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…d of range Co-authored-by: smith1511 <[email protected]>
parts/windows/windowscsehelper.ps1
Outdated
| "20348" { return "ltsc2022" } | ||
| "25398" { return "23H2" } | ||
| {$_ -ge "25399" -and $_ -le "30397"} { return "test2025" } | ||
| "26100" { return "test2025" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's update the returned version too - "test2025" => "2025"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the returned version from "test2025" to "2025" as requested. This change affects the Get-WindowsVersion function, containerd logic, all related tests, and regenerated test data files. Commit: 55311f6
Co-authored-by: smith1511 <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Can you rebase and regenerate test data please? |
The test data is already up to date. I ran |
Summary
Updates the Windows 2025 version detection in
windowscsehelper.ps1to use the specific build number "26100" instead of the previous vague range (25399-30397). This change provides precise version identification now that the actual Windows 2025 build number is known.Changes Made
Core Functions Updated
Get-WindowsVersion: Changed from range{$_ -ge "25399" -and $_ -le "30397"}to specific"26100"Get-WindowsPauseVersion: Changed from range{$_ -ge "25399" -and $_ -le "30397"}to specific"26100"Test Updates
Before/After
Before:
{$_ -ge "25399" -and $_ -le "30397"} { return "test2025" }After:
Validation
Evidence for Build Number
The Windows 2025 build number "26100" is confirmed by release notes found in:
vhdbuilder/release-notes/AKSWindows/2025/26100.4061.250518.txtvhdbuilder/release-notes/AKSWindows/2025-gen2/26100.4061.250518.txtThis change ensures precise version detection while maintaining all existing functionality for Windows 2025 systems.
Fixes #6559.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
baddomain.aks.azure.compwsh -c Invoke-Pester windowscsehelper.tests.ps1 -Verbose(dns block)pwsh -c Invoke-Pester windowscsehelper.tests.ps1 -Container (New-PesterContainer -Path 'windowscsehelper.tests.ps1' -Data @{ DescribeName = 'Get-WindowsVersion and Get-WindowsPauseVersion' })(dns block)pwsh -c Invoke-Pester windowscsehelper.tests.ps1 | Select-Object -ExpandProperty Tests | Where-Object { $_.Name -like '*Windows*2025*' -or $_.Name -like '*26100*' }(dns block)packages.aks.azure.compwsh -c Invoke-Pester windowscsehelper.tests.ps1 -Verbose(dns block)pwsh -c Invoke-Pester windowscsehelper.tests.ps1 -Container (New-PesterContainer -Path 'windowscsehelper.tests.ps1' -Data @{ DescribeName = 'Get-WindowsVersion and Get-WindowsPauseVersion' })(dns block)pwsh -c Invoke-Pester windowscsehelper.tests.ps1 | Select-Object -ExpandProperty Tests | Where-Object { $_.Name -like '*Windows*2025*' -or $_.Name -like '*26100*' }(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.