Disable default outbound access on master/worker subnets for hack/e2e clusters #4538
+44
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsatam
force-pushed
the
tsatam/e2e-cluster-disable-subnet-defaultoutboundaccess
branch
from
f27fe69 to
201c1ed
Compare
|
Please rebase pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes N/A
What this PR does / why we need it:
Disables defaultOutboundAccess on the master and worker subnets created during pkg/util/cluster's cluster creation (used for E2E and localdev contexts). This is done in order to match the upcoming change to default this value to false on new subnets: https://azure.microsoft.com/en-us/updates?id=default-outbound-access-for-vms-in-azure-will-be-retired-transition-to-a-new-method-of-internet-access
Note that in order to enable the presence of the
defaultOutboundAccessfield on subnets resources, this PR updates our Microsoft.Network apiversion used for ARM template generation to 2021-05-01. This will have implications for all ARM templates we apply, including during RP deployments and cluster creation steps performed by the RP.Test plan for issue:
Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
E2E-only change