Generate deep-copy functions #3967
Merged
+2,111
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deads2k
commented
Feb 2, 2026
Comment on lines
+58
to
+87
| # Fix internal Azure SDK import path and type references. | ||
| sed -i \ | ||
| -e 's|resource "github.com/Azure/azure-sdk-for-go/sdk/azcore/arm/internal/resource"|azcorearm "github.com/Azure/azure-sdk-for-go/sdk/azcore/arm"|g' \ | ||
| -e 's|resource\.ResourceID|azcorearm.ResourceID|g' \ | ||
| "${f}" | ||
|
|
||
| # Fix pointer-type azcorearm.ResourceID fields: replace two-line | ||
| # *out = new(azcorearm.ResourceID) | ||
| # (*in).DeepCopyInto(*out) | ||
| # with single-line call to DeepCopyResourceID. | ||
| sed -i -E \ | ||
| "/\*out = new\(azcorearm\.ResourceID\)/{N;s|\*out = new\(azcorearm\.ResourceID\)\n[[:space:]]*\(\*in\)\.DeepCopyInto\(\*out\)|*out = ${RESOURCEID_FUNC}(*in)|;}" \ | ||
| "${f}" | ||
|
|
||
| # Fix value-type azcorearm.ResourceID field (e.g. ServiceProviderCluster.ResourceID). | ||
| sed -i \ | ||
| "s/in\.ResourceID\.DeepCopyInto(&out\.ResourceID)/out.ResourceID = *${RESOURCEID_FUNC}(\&in.ResourceID)/g" \ | ||
| "${f}" | ||
|
|
||
| # Fix pointer-type time.Time fields (time.Time has no DeepCopyInto). | ||
| sed -i \ | ||
| '/\*out = new(time\.Time)/{n;s/(\*in)\.DeepCopyInto(\*out)/**out = **in/;}' \ | ||
| "${f}" | ||
|
|
||
| # Fix value-type time.Time fields. | ||
| for field in LastTransitionTime StartTime ExpirationTimestamp EndOfLifeTimestamp; do | ||
| sed -i \ | ||
| "s/in\.${field}\.DeepCopyInto(&out\.${field})/out.${field} = in.${field}/g" \ | ||
| "${f}" | ||
| done |
Collaborator
Author
There was a problem hiding this comment.
super ugly. probably still easier.
deads2k
commented
Feb 2, 2026
Comment on lines
+27
to
+32
| if [[ ! -z "$(git status --short)" ]]; then | ||
| echo "deepcopy generated files are out of date, rerun 'make deepcopy' to update them and check the changes in" | ||
| git status | ||
| git diff | ||
| exit 1 | ||
| fi |
Collaborator
Author
There was a problem hiding this comment.
also ugly (hate mutating the worktree), but in keeping with what we have.
deads2k
force-pushed
the
deepcopy-on-main
branch
from
cffb4cb to
4a226a1
Compare
Collaborator
Author
|
This looks good enough to me /hold cancel |
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collaborator
Author
|
/retest |
Contributor
deads2k
force-pushed
the
deepcopy-on-main
branch
from
4a226a1 to
234ea72
Compare
|
New changes are detected. LGTM label has been removed. |
Contributor
deads2k
force-pushed
the
deepcopy-on-main
branch
from
234ea72 to
bd84b1f
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ugly, but it appears accurate. It is using the kube deepcopy, but because we use azcorearm.ResourceID, we cannot create deepcopy functions on the type. Modification to deepcopy-gen is doable, but a long term effort.