Moved loggers from instance variables back to usage from context #3930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deads2k
commented
Jan 28, 2026
| newHash, err := w.hashFile(w.filePath) | ||
| if err != nil { | ||
| w.logger.Error(fmt.Errorf("failed to hash file during modification check: %w", err).Error()) | ||
| logger.Error(fmt.Errorf("failed to hash file during modification check: %w", err), "") |
Collaborator
Author
There was a problem hiding this comment.
equivalent, but I don't love it.
Collaborator
|
/test integration |
Collaborator
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, geoberle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Collaborator
|
/test e2e-parallel |
Contributor
Contributor
Contributor
|
/hold Revision 351b1f8 was retested 3 times: holding |
Collaborator
|
/test e2e-parallel |
Collaborator
Author
|
/hold cancel |
Collaborator
Author
|
all failures were provisioning failures. |
Contributor
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context holds more pertinent data. Also aligns with logr for frontend/backend
/assign @miguelsorianod @geoberle