Update the frontend.Run to not return until it is shutdown. #3927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deads2k
commented
Jan 28, 2026
deads2k
commented
Jan 28, 2026
deads2k
force-pushed
the
race-2
branch
3 times, most recently
from
1a8f039 to
22f289f
Compare
test-integration/utils/databasemutationhelpers/resource_crud_test_util.go
Show resolved
Hide resolved
test-integration/utils/databasemutationhelpers/resource_crud_test_util.go
Show resolved
Hide resolved
test-integration/utils/databasemutationhelpers/resource_crud_test_util.go
Show resolved
Hide resolved
This is accomplished by waiting for a context close and shutting down servers when that happens and returning if an error happens first.
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, miguelsorianod The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
geoberle
added a commit
that referenced
this pull request
Jan 30, 2026
#3927 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
that referenced
this pull request
Jan 30, 2026
#3927 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
that referenced
this pull request
Jan 30, 2026
#3927 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
that referenced
this pull request
Jan 30, 2026
#3927 Signed-off-by: Gerd Oberlechner <[email protected]>
geoberle
added a commit
that referenced
this pull request
Feb 1, 2026
#3927 Signed-off-by: Gerd Oberlechner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished by waiting for a context close and shutting down servers when that happens and returning if an error happens first.