*: limit HyperShift cluster sizes in dev #3876
Conversation
stevekuznetsov
force-pushed
the
skuznets/smaller-sizes-in-dev
branch
from
169dc92 to
16c63e4
Compare
There was a problem hiding this comment.
Ultimately - if E2E passes then it's good enough for me. I would be curious if we could measure what our new expected provisioning time is with these minimalistic resources. If these are the values we want to use for our tests - we'll need to come up with ways to exclude these from things like SLO reports on cluster provisioning times / etc (but that would be for any size differential from prod; outside of scope just something to think about)
| "helm.sh/hook-weight": "2" | ||
| spec: | ||
| concurrency: | ||
| limit: 9999 |
There was a problem hiding this comment.
I don't think we need to tweak this concurrency limit - in my read of hypershift, this does not impact new clusters - only "day 2" adjustments.
refs:
- https://github.com/openshift/hypershift/blob/9f235bbfaf8999cb1325f3c46c815e988460f93d/api/scheduling/v1alpha1/clustersizingconfiguration_types.go#L44-L51
- https://github.com/openshift/hypershift/blob/9f235bbfaf8999cb1325f3c46c815e988460f93d/hypershift-operator/controllers/hostedclustersizing/hostedclustersizing_controller_test.go#L1378
hypershiftoperator/deploy/templates/cluster.clustersizingconfiguration.yaml
Outdated
Show resolved
Hide resolved
hypershiftoperator/deploy/templates/cluster.clustersizingconfiguration.yaml
Outdated
Show resolved
Hide resolved
In the 'dev' cloud, we are never running true workloads on top of HostedClusters, so we never need the components running them to have any real requests and limits. Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
stevekuznetsov
force-pushed
the
skuznets/smaller-sizes-in-dev
branch
from
16c63e4 to
a777142
Compare
Starting E2E test mgmt clusters with one node and waiting for them to slowly scale up is a waste of our time. Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
Signed-off-by: Steve Kuznetsov <stekuznetsov@microsoft.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stevekuznetsov: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In the 'dev' cloud, we are never running true workloads on top of HostedClusters, so we never need the components running them to have any real requests and limits.