backend: Move credential polling to dedicated controllers #3873
Conversation
backend/pkg/controllers/operationcontrollers/generic_operation.go
Outdated
Show resolved
Hide resolved
backend/pkg/controllers/operationcontrollers/operation_request_credential.go
Outdated
Show resolved
Hide resolved
backend/pkg/controllers/operationcontrollers/operation_revoke_credentials.go
Outdated
Show resolved
Hide resolved
backend/pkg/controllers/operationcontrollers/operation_revoke_credentials.go
Outdated
Show resolved
Hide resolved
This was not meant to be operation-specific, but rather reusable for most if not all operation controllers. New name is NewGenericOperationController.
mbarnes
force-pushed
the
1p/admin-credential-controller
branch
from
c98f96d to
c03aa22
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mbarnes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-parallel |
|
/retest-required |
|
@mbarnes: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What
Getting my feet wet with the backend controller pattern. This converts handling of "request credential" and "revoke credentials" operations to dedicated controllers.