-
Notifications
You must be signed in to change notification settings - Fork 105
Update image-updater targets in Makefile #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/approve |
| # Install EPEL for additional packages | ||
| RUN dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm | ||
| # Install all packages in one layer | ||
| RUN dnf install -y azure-cli libicu make git procps-ng skopeo jq && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jq, yq, and any other tool managed by .bingo must be installed using that pattern. Any script, Make target, or other software expecting to use system jq must be refactored to use the one installed by .bingo. The point of managing the dependencies that way is that:
- all
Make-derivative actions can always ensure their requirements are installed with no setup steps - it's trivial to manage the versions of these tools - and it's explicit which version is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah agreed . Like I mentioned earlier use the install-tools target as an example .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jq, yq are already present in the target by the way .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fails to install skopeo due to C dependencies. So, removed.
bingo get github.com/containers/skopeo/cmd/skopeo@latest
Bingo not used before here, creating directory for pinned modules for you at .bingo
Error: get: skopeo.mod: getting github.com/containers/skopeo/cmd/skopeo@latest: install: build versioned: github.com/proglottis/gpgme: build constraints exclude all Go files in /home/hbhushan/go/pkg/mod/github.com/proglottis/gpgme@v0.1.5
: exit 1
Usage:
bingo get [flags] [<package or binary>[@version1 or none,version2,version3...]]
Examples:
bingo get github.com/fatih/faillint
....................
get: skopeo.mod: getting github.com/containers/skopeo/cmd/skopeo@latest: install: build versioned: github.com/proglottis/gpgme: build constraints exclude all Go files in /home/hbhushan/go/pkg/mod/github.com/proglottis/gpgme@v0.1.5
: exit 1
|
/hold This is not the right thing to be doing. |
| # Install EPEL for additional packages | ||
| RUN dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm | ||
| # Install all packages in one layer | ||
| RUN dnf install -y azure-cli libicu make git procps-ng skopeo jq && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hbhushan3 I mentioned this to @raelga yesterday . Kindly use the make install-tools target for all this .
a8ab481 to
9316d08
Compare
raelga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbhushan3, raelga, weherdh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
@hbhushan3: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
image-updaterintoimage-updater-buildandimage-updater-updatetargets for better granularityTesting
✅
make image-updater-updateruns successfully✅
make image-updater-buildruns successfully