Skip to content

Conversation

@hbhushan3
Copy link
Collaborator

@hbhushan3 hbhushan3 commented Jan 22, 2026

  • Improved Makefile: Split image-updater into image-updater-build and image-updater-update targets for better granularity

Testing

make image-updater-update runs successfully
make image-updater-build runs successfully

@weherdh
Copy link
Collaborator

weherdh commented Jan 22, 2026

/approve

# Install EPEL for additional packages
RUN dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm
# Install all packages in one layer
RUN dnf install -y azure-cli libicu make git procps-ng skopeo jq && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jq, yq, and any other tool managed by .bingo must be installed using that pattern. Any script, Make target, or other software expecting to use system jq must be refactored to use the one installed by .bingo. The point of managing the dependencies that way is that:

  1. all Make-derivative actions can always ensure their requirements are installed with no setup steps
  2. it's trivial to manage the versions of these tools - and it's explicit which version is used

Copy link
Collaborator

@venkateshsredhat venkateshsredhat Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah agreed . Like I mentioned earlier use the install-tools target as an example .

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jq, yq are already present in the target by the way .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails to install skopeo due to C dependencies. So, removed.

bingo get github.com/containers/skopeo/cmd/skopeo@latest
Bingo not used before here, creating directory for pinned modules for you at .bingo
Error: get: skopeo.mod: getting github.com/containers/skopeo/cmd/skopeo@latest: install: build versioned: github.com/proglottis/gpgme: build constraints exclude all Go files in /home/hbhushan/go/pkg/mod/github.com/proglottis/gpgme@v0.1.5
: exit 1
Usage:
  bingo get [flags] [<package or binary>[@version1 or none,version2,version3...]]

Examples:
bingo get github.com/fatih/faillint
....................
get: skopeo.mod: getting github.com/containers/skopeo/cmd/skopeo@latest: install: build versioned: github.com/proglottis/gpgme: build constraints exclude all Go files in /home/hbhushan/go/pkg/mod/github.com/proglottis/gpgme@v0.1.5
: exit 1

@stevekuznetsov
Copy link
Contributor

/hold
/approve cancel
/lgtm cancel

This is not the right thing to be doing.

# Install EPEL for additional packages
RUN dnf install -y https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm
# Install all packages in one layer
RUN dnf install -y azure-cli libicu make git procps-ng skopeo jq && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbhushan3 I mentioned this to @raelga yesterday . Kindly use the make install-tools target for all this .

@hbhushan3 hbhushan3 changed the title Enhance OpenShift CI Base Image with Container Tools Update image-updater targets in Makefile Jan 23, 2026
Copy link
Collaborator

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbhushan3, raelga, weherdh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbhushan3
Copy link
Collaborator Author

/unhold

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1fcc572 and 2 for PR HEAD 9316d08 in total

@openshift-ci
Copy link

openshift-ci bot commented Jan 24, 2026

@hbhushan3: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-parallel 9316d08 link true /test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants