Add controller to delete orphaned cosmos resources #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once c23fb55 makes it to production, we can rely on the new cosmosUID being predictable based on resourceID. By doing this we're able to derive resourceID which is important elsewhere. Also eliminates cosmosUID since it is an unnessary field to store since it is always derivable.
Since we migrated all the data in int, stg, and prod, the existing fixtures no longer match. Update them all to match so we can continue testing the database layer.
We found that may controllers weren't getting cleaned up. We need to find and fix that problem, but we also need to clean up the data we have. This adds a controller that cleans up ones that already escaped and will continue to do so. It works in a way that should scale for order of low tens of thousands of resources to scan in a reasonable timeframe.
deads2k
force-pushed
the
controller-02-delete-full-orphan
branch
from
dbe4979 to
df53dea
Compare
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, geoberle The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that may controllers weren't getting cleaned up. We need to find and fix that problem, but we also need to clean up the data we have. This adds a controller that cleans up ones that already escaped and will continue to do so. It works in a way that should scale for order of low tens of thousands of resources to scan in a reasonable timeframe.
Adds controller for deleting orphaned data. Relies on other PRs and needs testing.
/hold