Skip to content

E2E test for back-level cluster version (4.19) installation #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mvacula02 wants to merge 14 commits into
base: main
Choose a base branch
from
Open

E2E test for back-level cluster version (4.19) installation #3799

mvacula02 wants to merge 14 commits into from
+200 −4

Conversation

@mvacula02
Copy link
Collaborator

@mvacula02 mvacula02 commented Jan 15, 2026 •
edited
Loading

ARO-23474

What

New positive E2E test case: ensure cluster and node pool creation supports back-level versions (4.19)

The test:

  • creates cluster(s) with version backlevel version(s)
  • verifies cluster ingress functionality
  • creates node pools (4.y.0, 4.y.z-1, 4.y.z versions) in parallel, matches node pool version to corresponding cluster based on minor release
  • verifies the nodes within node pools can run workload through a simple pod scheduling test a simple web app

@openshift-ci
Copy link

openshift-ci bot commented Jan 15, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

aklymenk
aklymenk reviewed Jan 15, 2026
View reviewed changes
@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 15, 2026 •
edited
Loading

TO-DO:

  • create a function in deployment_helper.go that returns a list of supported versions
  • node pool workload verifier
  • remove persistTagValue
  • use existing node pool workload verifier. Either use serving app with different topology constraints or implement node selector
  • decide whether to test multiple node pool versions
  • use env variables to get supported back level versions
  • assign MIs after knowing how many clusters will be created by the test
  • copy default clusterParams
  • remove currently unneccesary waitGroup for node pools
  • copy default nodePoolParams

@mvacula02 mvacula02 marked this pull request as ready for review January 16, 2026 13:30
@openshift-ci openshift-ci bot requested review from bennerv and deads2k January 16, 2026 13:30
@mvacula02 mvacula02 requested a review from mbukatov January 16, 2026 13:35
@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 16, 2026

/retest

@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 16, 2026

/test periodic-images

1 similar comment
@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 16, 2026

/test periodic-images

@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 16, 2026

/retest

stevekuznetsov
stevekuznetsov reviewed Jan 16, 2026
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jan 16, 2026
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jan 16, 2026
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jan 16, 2026
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jan 16, 2026
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jan 16, 2026
View reviewed changes
stevekuznetsov
stevekuznetsov reviewed Jan 16, 2026
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this runs only in some relatively rare periodic. We don't get value from running it on every deploy

@deads2k
Copy link
Collaborator

deads2k commented Jan 19, 2026

I have not done a detailed review, but one critical thing to do is to copy/paste the infrastructure and the cluster create so that they never change when we evolve the main fixtures. The point of this is that old customer automation always works forever.

@deads2k
Copy link
Collaborator

deads2k commented Jan 19, 2026

Please make sure this runs only in some relatively rare periodic. We don't get value from running it on every deploy

Maybe later. I wouldn't get picky now and we need to ensure this is on the blocking path for promotion deployments.

@mvacula02 mvacula02 marked this pull request as draft January 19, 2026 14:34
deads2k
deads2k reviewed Jan 23, 2026
View reviewed changes
test/e2e/cluster_version_backlevel.go Outdated
clusterParams.ImageRegistryState = "Enabled"
clusterParams.ChannelGroup = "stable"

clusterParams, err := tc.CreateClusterCustomerResources(ctx,
Copy link
Collaborator

@deads2k deads2k Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function still uses WithTemplateFromFS(artifactsFS, "test-artifacts/generated-test-artifacts/modules/customer-infra.json"),. We need taht content copied for 4.19 so it remains insulated from any future change.

deads2k
deads2k reviewed Jan 23, 2026
View reviewed changes
test/e2e/cluster_version_backlevel.go Outdated
}

By("creating HCP cluster version " + controlPlaneVersion)
err = tc.CreateHCPClusterFromParam(
Copy link
Collaborator

@deads2k deads2k Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This call still uses BuildHCPClusterFromParams(parameters, tc.Location()). We must have a 4.19 copy of that function so that changes in it don't sneak into our 4.19 testing.

@deads2k
Copy link
Collaborator

deads2k commented Jan 23, 2026

I've accepted an IOU to be paid off next week for making copies of the customer infra, cluster-create, and node create that make these older one independent of any other level.

/approve

/assign @mbukatov
(or delegate) for lgtm.

mbukatov
mbukatov reviewed Jan 23, 2026
View reviewed changes
Copy link
Collaborator

@mbukatov mbukatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2026
@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 23, 2026

/test test-unit

@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 23, 2026

/test e2e-parallel

@openshift-ci openshift-ci bot removed the lgtm label Jan 23, 2026
@mgahagan73
Copy link
Collaborator

mgahagan73 commented Jan 23, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mbukatov, mgahagan73, mvacula02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 24, 2026

/retest-required

Remaining retests: 0 against base HEAD 1fcc572 and 2 for PR HEAD fbc7ae8 in total

@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 24, 2026

/test e2e-parallel

4 similar comments
@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 24, 2026

/test e2e-parallel

@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 24, 2026

/test e2e-parallel

@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 24, 2026

/test e2e-parallel

@mvacula02
Copy link
Collaborator Author

mvacula02 commented Jan 25, 2026

/test e2e-parallel

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2026

/retest-required

Remaining retests: 0 against base HEAD 8477d88 and 1 for PR HEAD fbc7ae8 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 25, 2026

/retest-required

Remaining retests: 0 against base HEAD 2ff7bb3 and 0 for PR HEAD fbc7ae8 in total

@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2026

@mvacula02: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-parallel fbc7ae8 link true /test e2e-parallel

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 26, 2026

/hold

Revision fbc7ae8 was retested 3 times: holding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbukatov mbukatov mbukatov left review comments

@deads2k deads2k deads2k left review comments

@aklymenk aklymenk aklymenk left review comments

@bennerv bennerv Awaiting requested review from bennerv

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@mbukatov mbukatov

@mgahagan73 mgahagan73

Labels

approved do-not-merge/hold lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mvacula02 @deads2k @mgahagan73 @openshift-ci-robot @mbukatov @stevekuznetsov @aklymenk