feat: (#80) Add quorumVotes to ProposalData #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OT-kraftchain
changed the title
OT-kraftchain
changed the title
OT-kraftchain
force-pushed
the
feat/80_absolute_quorum
branch
from
d2cebc4 to
cb8188c
Compare
mialbu
requested changes
Apr 23, 2025
Member
mialbu
left a comment
mialbu
left a comment
There was a problem hiding this comment.
Some minor requests and I'd like to have a test that checks the migration code. Please check my first second comment about it.
OT-kraftchain
force-pushed
the
feat/80_absolute_quorum
branch
from
2957bfa to
7900805
Compare
OT-kraftchain
force-pushed
the
feat/80_absolute_quorum
branch
from
7900805 to
3fe2f71
Compare
mialbu
requested changes
May 22, 2025
Member
mialbu
left a comment
mialbu
left a comment
There was a problem hiding this comment.
It's almost there now. There's only one piece we still need to change, now that we migrate all proposals in storage. Please check the comment with my suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.