WAL-170-automatically-add-wallaby-runs-to-the-relevant-survey-components-based-on-name #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…survey-components-based-on-name' of https://github.com/AusSRC/SoFiAX_services into WAL-170-automatically-add-wallaby-runs-to-the-relevant-survey-components-based-on-name
…-the-relevant-survey-components-based-on-name
axshen
reviewed
Jul 8, 2025
axshen
reviewed
Jul 8, 2025
Contributor
There was a problem hiding this comment.
Is there a reason we don't replace get_survey_component_by_name with just SurveyComponent.objects.get(name=in_name)?
Contributor
Author
There was a problem hiding this comment.
because I didn't know you can do that. I'll update this too.
Contributor
Author
There was a problem hiding this comment.
Actually using filter avoids getting a "DoesNotExist" exception and it will change the way I handle displaying error messages
axshen
reviewed
Jul 8, 2025
web/survey/admin.py
Outdated
| def _auto_assign_to_component(self, request, queryset): | ||
| try: | ||
| self.auto_assign_run_to_component(request, queryset) | ||
| return redirect('/admin/survey/run/') |
Contributor
There was a problem hiding this comment.
Why are we redirecting to the run page? The user starts at the survey component run page, and then this would take the user to a different page right?
Contributor
Author
There was a problem hiding this comment.
Yep thanks, I have removed the redirect.
axshen
approved these changes
Jul 9, 2025
riniangreani
deleted the
WAL-170-automatically-add-wallaby-runs-to-the-relevant-survey-components-based-on-name
branch
axshen
added a commit
that referenced
this pull request
Nov 3, 2025
…nts-based-on-name (#27) * Update README.md * Update README.md * Add function to auto assign survey runs to components * Add description for auto-assign action * Make sure user messages work for auto-assign * Update lint.yml * Linting fixes * Update README.md with wallaby version * Linting fixes * Austin feedback * Fix wrong name pattern for quality check --------- Co-authored-by: Austin Shen <austin.shen@csiro.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new menu in Runs:
Results and errors after run:
