This repository was archived by the owner on Jan 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Launch features #5
Open
agnoster
wants to merge
75
commits into
master
Choose a base branch
from
launch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
17ace17
cp
slobak f52ac5a
removed options
slobak 4397aa3
moved success/error
slobak f42933a
fix typekit
slobak dc8478a
styling
slobak 15ee2ff
changing layout, wip
slobak 401fdb8
fixed API communication
slobak d222331
basic typeahead, no keyboard selection yet
slobak a9dfbb6
keyboard selection, kinda working
slobak 97d1b76
better keyb selection
slobak e452950
working scrolling on keyboard
slobak 891936f
Grab favicon url from page and fix some bugs
slobak d5e8466
Fix resize bug, and show contacts in order
slobak f2c7be9
Fix task creation functionality, add logging
slobak b0f447a
Load correct typekit for locale
slobak a6162f3
Checkpoint.
6e39ad1
More changes.
150085b
Finalized CSS.
fd957b6
added logging, default assigned to logged-in user
slobak 55d1b87
fix client name
slobak 79abe6c
fixed initial rendering of assignee
slobak c6b218c
assignee looks like no one but is self by default
slobak 5fbabd3
cp
slobak 2afbf1a
Alt and Tab hotkeys are now more robust
slobak 82c8dbf
fill in field with selected user's name
slobak 9276a4d
fix dimensions for popup
slobak ccc52ab
select on hover
slobak af5324f
Final styling.
96ac135
Updated comments
slobak 221f12e
Update signup link
slobak 3831898
Log workspace change
slobak 0fb9a95
Increase photo resolution, better for retina display
slobak 334e64d
Fix breakage on workspace change when assignee already selected
slobak 7e3f79e
anonymous man
4a22c90
Fix scrollwheel scrolling of assignee list
slobak b4df96f
Merge branch 'launch' of github.com:Asana/Chrome-Extension-Example in…
slobak b3dbb03
Added silhouette
slobak 9c509c1
Update 128px icon
slobak 965e75e
Update manifest with more appropriate configuration
slobak 5992756
Always put current user first
slobak fbc435c
Moved to use command API instead of a content script
slobak 8a8c343
reduce content script execution to just getting selection
slobak 558a441
Update README
slobak 03a957f
final fixes.
cdfcca3
Default assignee to current user, update filtered list when opened, r…
slobak 530704f
Don't focus popup body
slobak fe27575
Use browser action for command and switch keyboard shortcut to Alt+Sh…
slobak 5e5bbdb
Fix wrapping on completion
slobak 28b4920
Fix broken font
slobak ab2a0aa
Update version for type fix
slobak f6cca47
Adding client header to API requests
e2d9938
Fix banner icon alignment
973b234
Update icons for visual relaunch (still does not have new styles in U…
04fe5ae
Add a LICENSE file
chadworth fb323b0
Merge pull request #10 from chadworth/patch-1
slobak 090e5ed
Reduce tab permission to just what is necessary
20bd3a2
Changes the user-selection to use type-ahead instead of caching all t…
periodic 5ee06e2
Removes unused user filtering code.
periodic c6a368c
Removes the XHR abort code since it doesn't actually do anything.
periodic 33d98b6
Cleans up some debugging code and adds a missing semicolon.
1554560
First pass at updated design: inputs, typeahead, logo, colors
6e00b74
Further design tweaks - status messages, icons
bccca04
Bump manifest version
18aafe6
Update font usage
90d54f7
Remove typekit permissions and improve icon
54b35b6
Merge pull request #12 from Asana/quick-redesign
slobak 55f4626
Merges in UI updates.
e3966c3
Minor fix-ups.
b20720f
Changes the user-selection to use type-ahead.
periodic e0123f3
Fixes some style errors.
083cfd5
Fixes some style errors.
periodic af5fbdb
Bumps manifest version.
4d9e1c8
Merge pull request #15 from Asana/drewhaven-bump-manifest
periodic 4c72747
Prevents duplicate click handlers on the button.
periodic 05782e4
Merge pull request #16 from Asana/drewhaven/too-many-tasks
periodic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| The MIT License (MIT) | ||
| Copyright (c) 2013-2015 Asana | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,68 @@ | ||
| /** | ||
| * Define the top-level Asana namespace. | ||
| */ | ||
| Asana = {}; | ||
| Asana = { | ||
|
|
||
| // When popping up a window, the size given is for the content. | ||
| // When resizing the same window, the size must include the chrome. Sigh. | ||
| CHROME_TITLEBAR_HEIGHT: 24, | ||
| // Natural dimensions of popup window. The Chrome popup window adds 10px | ||
| // bottom padding, so we must add that as well when considering how tall | ||
| // our popup window should be. | ||
| POPUP_UI_HEIGHT: 310 + 10, | ||
| POPUP_UI_WIDTH: 410, | ||
| // Size of popup when expanded to include assignee list. | ||
| POPUP_EXPANDED_UI_HEIGHT: 310 + 10 + 129, | ||
|
|
||
| // If the modifier key is TAB, amount of time user has from pressing it | ||
| // until they can press Q and still get the popup to show up. | ||
| QUICK_ADD_WINDOW_MS: 5000 | ||
|
|
||
|
|
||
| }; | ||
|
|
||
| /** | ||
| * Things borrowed from asana library. | ||
| */ | ||
|
|
||
|
|
||
| Asana.update = function(to, from) { | ||
| for (var k in from) { | ||
| to[k] = from[k]; | ||
| } | ||
| return to; | ||
| }; | ||
|
|
||
| Asana.Node = { | ||
|
|
||
| /** | ||
| * Ensures that the bottom of the element is visible. If it is not then it | ||
| * will be scrolled up enough to be visible. | ||
| * | ||
| * Note: this does not take account of the size of the window. That's ok for | ||
| * now because the scrolling element is not the top-level element. | ||
| */ | ||
| ensureBottomVisible: function(node) { | ||
| var el = $(node); | ||
| var pos = el.position(); | ||
| var element_from_point = document.elementFromPoint( | ||
| pos.left, pos.top + el.height()); | ||
| if (element_from_point === null || | ||
| $(element_from_point).closest(node).size() === 0) { | ||
| node.scrollIntoView(/*alignWithTop=*/ false); | ||
| } | ||
| } | ||
|
|
||
| }; | ||
|
|
||
| if (!RegExp.escape) { | ||
| // Taken from http://simonwillison.net/2006/Jan/20/escape/ | ||
| RegExp.escape = function(text, opt_do_not_escape_spaces) { | ||
| if (opt_do_not_escape_spaces !== true) { | ||
| return text.replace(/[-[\]{}()*+?.,\\^$|#\s]/g, "\\$&"); // nolint | ||
| } else { | ||
| // only difference is lack of escaping \s | ||
| return text.replace(/[-[\]{}()*+?.,\\^$|#]/g, "\\$&"); // nolint | ||
| } | ||
| }; | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| Asana.ExtensionServer.listen(); | ||
| Asana.ServerModel.startPrimingCache(); | ||
|
|
||
| // Modify referer header sent to typekit, to allow it to serve to us. | ||
| // See http://stackoverflow.com/questions/12631853/google-chrome-extensions-with-typekit-fonts | ||
| chrome.webRequest.onBeforeSendHeaders.addListener(function(details) { | ||
| var requestHeaders = details.requestHeaders; | ||
| for (var i = 0; i < requestHeaders.length; ++i) { | ||
| if (requestHeaders[i].name.toLowerCase() === 'referer') { | ||
| // The request was certainly not initiated by a Chrome extension... | ||
| return; | ||
| } | ||
| } | ||
| // Set Referer | ||
| requestHeaders.push({ | ||
| name: 'referer', | ||
| // Host must match the domain in our Typekit kit settings | ||
| value: 'https://abkfopjdddhbjkiamjhkmogkcfedcnml' | ||
| }); | ||
| return { | ||
| requestHeaders: requestHeaders | ||
| }; | ||
| }, { | ||
| urls: ['*://use.typekit.net/*'], | ||
| types: ['stylesheet', 'script'] | ||
| }, ['requestHeaders','blocking']); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this actually
ALT+SHIFT+A?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it is in fact ALT+A, that would be most unfortunate, as that key is used by certain international keyboards to write accented characters.