-
Notifications
You must be signed in to change notification settings - Fork 12
Modified ability input upgrade #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new “Expand Ability Inputs” setting and updates combat dialogs to always show or toggle detailed ability modifier inputs. It also introduces a reusable ModifiersList component across multiple attack and defense dialogs and makes related styling adjustments.
- Register a new
EXPAND_ABILITY_INPUTSworld setting inregisterSettings.js. - Enhance
ModifiedAbilityInput.svelteto support expandable inputs and operator logic. - Inject
ModifiersListinto various combat dialog components and adjust layout/CSS.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/registerSettings.js | Add new setting key and registration for expanding inputs |
| src/svelte/ui/modifiersList.svelte | Adjust font-size CSS—introduce and override a custom variable |
| src/svelte/ui/modifiedAbilityInput.svelte | Implement expandable input fields with operator handling |
| src/svelte/ui/card/contractibleCard.svelte | Tweak container height and comment out positioning |
| src/svelte/ui/card/combatCard.svelte | Insert modifiers panel, tweak gaps and positioning |
| src/module/combat/results/ResultsDialog.svelte | Switch header/image alt to token but still fetch actor image |
| src/module/combat/defense/*.svelte | Import and render ModifiersList |
| src/module/combat/attack/*.svelte | Import and render ModifiersList |
| src/lang/{fr,es,en}.json | Add localization entries for the new setting |
| @use 'card'; | ||
| .modifier-row { | ||
| --font-size: 16px; | ||
| --font-size: 22px; |
Copilot
AI
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The --font-size variable is defined but never used, since you override the font-size with a fixed 16px. Consider removing the unused CSS variable or applying it consistently via font-size: var(--font-size).
| min-height: $title-height; | ||
| position: relative; | ||
| height: 100%; | ||
| // position: relative; |
Copilot
AI
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider removing this commented-out position: relative; to reduce clutter and avoid confusion about the intended layout.
| // position: relative; |
No description provided.