Skip to content

Conversation

@Eryx5502
Copy link
Contributor

@Eryx5502 Eryx5502 commented Jun 7, 2025

No description provided.

@Eryx5502 Eryx5502 requested a review from Copilot June 7, 2025 19:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new “Expand Ability Inputs” setting and updates combat dialogs to always show or toggle detailed ability modifier inputs. It also introduces a reusable ModifiersList component across multiple attack and defense dialogs and makes related styling adjustments.

  • Register a new EXPAND_ABILITY_INPUTS world setting in registerSettings.js.
  • Enhance ModifiedAbilityInput.svelte to support expandable inputs and operator logic.
  • Inject ModifiersList into various combat dialog components and adjust layout/CSS.

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/utils/registerSettings.js Add new setting key and registration for expanding inputs
src/svelte/ui/modifiersList.svelte Adjust font-size CSS—introduce and override a custom variable
src/svelte/ui/modifiedAbilityInput.svelte Implement expandable input fields with operator handling
src/svelte/ui/card/contractibleCard.svelte Tweak container height and comment out positioning
src/svelte/ui/card/combatCard.svelte Insert modifiers panel, tweak gaps and positioning
src/module/combat/results/ResultsDialog.svelte Switch header/image alt to token but still fetch actor image
src/module/combat/defense/*.svelte Import and render ModifiersList
src/module/combat/attack/*.svelte Import and render ModifiersList
src/lang/{fr,es,en}.json Add localization entries for the new setting

@use 'card';
.modifier-row {
--font-size: 16px;
--font-size: 22px;
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The --font-size variable is defined but never used, since you override the font-size with a fixed 16px. Consider removing the unused CSS variable or applying it consistently via font-size: var(--font-size).

Copilot uses AI. Check for mistakes.
min-height: $title-height;
position: relative;
height: 100%;
// position: relative;
Copy link

Copilot AI Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing this commented-out position: relative; to reduce clutter and avoid confusion about the intended layout.

Suggested change
// position: relative;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants