Skip to content

Conversation

@loomts
Copy link
Contributor

@loomts loomts commented Dec 24, 2025

Resolved #1311 , to simplify the config, I just reuse the tls config of clickhouse.
According to https://clickhouse.com/docs/operations/ssl-zookeeper, the sample use OS RootCAs, which can also be handle.

Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add parsing /*/client/* from /var/lib/clickhouse/preprocessed_configs/config.xml
when isSecure true instead of using clickhouse TLS connection setting

moreover, could you add zookeeper and keeper tls settings to /tests/integration/docker-compose*.yml and /tests/integration/dynamic_settings.sh

and test it via
RUN_TESTS=^TestS3$ ./test/integration/run.sh

@Slach
Copy link
Collaborator

Slach commented Dec 24, 2025

thanks you for your contribution

@Slach Slach added this to the 2.6.42 milestone Dec 24, 2025
@coveralls
Copy link

coveralls commented Dec 24, 2025

Pull Request Test Coverage Report for Build 20569484255

Details

  • 19 of 90 (21.11%) changed or added relevant lines in 3 files are covered.
  • 274 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-1.8%) to 66.911%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/clickhouse/clickhouse.go 2 3 66.67%
pkg/utils/utils.go 8 25 32.0%
pkg/keeper/keeper.go 9 62 14.52%
Files with Coverage Reduction New Missed Lines %
pkg/backup/restore.go 1 71.75%
pkg/clickhouse/clickhouse.go 1 78.54%
cmd/clickhouse-backup/main.go 2 75.21%
pkg/storage/object_disk/object_disk.go 5 66.3%
pkg/config/config.go 8 72.64%
pkg/status/status.go 9 67.43%
pkg/server/server.go 11 58.54%
pkg/storage/general.go 12 61.02%
pkg/backup/backuper.go 17 70.95%
pkg/storage/s3.go 23 47.39%
Totals Coverage Status
Change from base Build 20459974961: -1.8%
Covered Lines: 10952
Relevant Lines: 16368

💛 - Coveralls

@Slach
Copy link
Collaborator

Slach commented Dec 28, 2025

@loomts any news about requested changes?

@loomts
Copy link
Contributor Author

loomts commented Dec 29, 2025

@loomts any news about requested changes?

@Slach I fixed according to the comments, PTAL.

@loomts loomts requested a review from Slach December 29, 2025 09:51
Copy link
Collaborator

@Slach Slach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for your contribution, looks great!

@Slach Slach merged commit 50f9d3f into Altinity:master Jan 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support tls for keeper and clickhouse communication

3 participants