-
Notifications
You must be signed in to change notification settings - Fork 14
[OGUI-1852] Open Bookkeeping from RunNumber ObjectInfoPanel #3272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[OGUI-1852] Open Bookkeeping from RunNumber ObjectInfoPanel #3272
Conversation
…kkeeping is configured
| strictEqual(baseUrl, `${config.bookkeeping.url}/`); | ||
| strictEqual(runNumber, url.searchParams.get('runNumber')) | ||
| } | ||
| ) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note test
the enclosing function
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 16 hours ago
In general, to avoid problems with automatic semicolon insertion, each statement should be explicitly terminated with a semicolon, especially when the next line begins with characters that could be parsed ambiguously. Here, the call to strictEqual on line 239 should be explicitly terminated.
The minimal fix without changing functionality is to add a semicolon at the end of line 239, turning strictEqual(runNumber, url.searchParams.get('runNumber')) into strictEqual(runNumber, url.searchParams.get('runNumber'));. This keeps the test logic identical while making the statement termination explicit and consistent with the rest of the file. No new imports, methods, or definitions are needed; only the one line is updated in QualityControl/test/public/pages/object-tree.test.js.
-
Copy modified line R239
| @@ -236,7 +236,7 @@ | ||
| const baseUrl = `${url.origin}${url.pathname}`; | ||
|
|
||
| strictEqual(baseUrl, `${config.bookkeeping.url}/`); | ||
| strictEqual(runNumber, url.searchParams.get('runNumber')) | ||
| strictEqual(runNumber, url.searchParams.get('runNumber')); | ||
| } | ||
| ) | ||
|
|
I have JIRA issue created
The user should be able to press on an icon that is to be displayed in the object info panel and navigate in a NEW tab to bookkeeipng run-details page of that run number.
For example, at start we load
filter/configurationwhere we send data loaded on server start.We should add a new endpoint:
serviceswhich returns an object of services and their connection links. For start, we will only provide in this object the configuraiton of bookkeeping service:Please add:
Then on front-end side use this data to build the URL needed to access bookkeeping on the run-details page
e.g. of URL
https://ali-bookkeeping.cern.ch/?page=run-detail&runNumber=568864The button should be an icon next to the runNumber and should not be copied when cliking on runNumber
Moreover, if Bookkeeping is not present in the config.js file, this button should not be displayed