QC-1320 Suppress DomainInfoHeader traffic in remote QC workflows #2634
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed that DomainInfoHeader (DIH) is propagated throughout the whole topology for every message received by the proxy. There is no point in that, because Merger outputs are based in a different time domain and also because all downstream QC data processors consume data immediatelly, thus there is no risk of accumulating inputs. The label which disables DIH propagation is added to: - remote input proxy for local QC tasks to cut the unneccessary traffic as early as possible in remote QC workflows - Mergers, to see a similar behaviour when testing QC with `--full-chain` option (it adds Mergers, but not proxies) The label is *not* added for remote proxies of remote tasks, because it *does* make sense to propagate DIH for data samples, which might have to be synchronized as QC task inputs. This being said, I am not sure if the synchronization works in this case anyway, given that input proxies assign new timesliceIDs to messages...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed that DomainInfoHeader (DIH) is propagated throughout the whole topology for every message received by the proxy. There is no point in that, because Merger outputs are based in a different time domain and also because all downstream QC data processors consume data immediatelly, thus there is no risk of accumulating inputs.
The label which disables DIH propagation is added to:
--full-chainoption (it adds Mergers, but not proxies)The label is not added for remote proxies of remote tasks, because it does make sense to propagate DIH for data samples, which might have to be synchronized as QC task inputs. This being said, I am not sure if the synchronization works in this case anyway, given that input proxies assign new timesliceIDs to messages...