Skip to content

Fix/fix tests that fail probabilistically#2118

Merged
isaachilly merged 9 commits intomainfrom
fix/fix-tests-that-fail-probabilistically
Mar 26, 2026
Merged

Fix/fix tests that fail probabilistically#2118
isaachilly merged 9 commits intomainfrom
fix/fix-tests-that-fail-probabilistically

Conversation

@NarrowsProjects
Copy link
Collaborator

@NarrowsProjects NarrowsProjects commented Mar 19, 2026

I DON'T have JIRA ticket

  • explain what this PR does
  • if it is a new feature, explain how you plan to use it
  • tests are added
  • documentation was updated or added

For some time, certain integration tests seemed to have a chance to fail.

This PR fixes some of those tests.

  • All tests that fail due to node-detached-from-document errors
  • 'should successfully discard all QC flags for the data pass' Which would fail due to not finding any changes in the table
  • All tests that fail due to validateTableData stating there are no rows

@NarrowsProjects NarrowsProjects self-assigned this Mar 19, 2026
@NarrowsProjects NarrowsProjects added javascript Pull requests that update Javascript code bug Something isn't working labels Mar 19, 2026
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.53%. Comparing base (3a4525d) to head (76bb2cb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2118   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files        1044     1044           
  Lines       17344    17344           
  Branches     3145     3145           
=======================================
  Hits         7897     7897           
  Misses       9447     9447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the fix/fix-tests-that-fail-probabilistically branch 4 times, most recently from 810f3dd to 3237bbc Compare March 26, 2026 15:00
@NarrowsProjects NarrowsProjects force-pushed the fix/fix-tests-that-fail-probabilistically branch from 3237bbc to 5bf4637 Compare March 26, 2026 15:02
@NarrowsProjects NarrowsProjects force-pushed the fix/fix-tests-that-fail-probabilistically branch from 854b7ea to 76fc459 Compare March 26, 2026 15:20
@isaachilly isaachilly merged commit 4903cda into main Mar 26, 2026
23 of 24 checks passed
@isaachilly isaachilly deleted the fix/fix-tests-that-fail-probabilistically branch March 26, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants