Skip to content

start_tmux.sh: remove double-checking for existing shm segments#15214

Merged
ehellbar merged 1 commit intoAliceO2Group:devfrom
ehellbar:pr15214
Mar 25, 2026
Merged

start_tmux.sh: remove double-checking for existing shm segments#15214
ehellbar merged 1 commit intoAliceO2Group:devfrom
ehellbar:pr15214

Conversation

@ehellbar
Copy link
Collaborator

@ehellbar ehellbar commented Mar 25, 2026

No description provided.

@ehellbar ehellbar requested a review from a team as a code owner March 25, 2026 13:01
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ehellbar
Copy link
Collaborator Author

the shm segment check is already done here

if [[ -z $SHM_MANAGER_SHMID ]]; then
, taking into account the possibility of segments from the shm-manager

@davidrohr
Copy link
Collaborator

This was added by @ChSonnabend , since he said the test failed for him due to existing files.
Actually I did not check back then, even though I supposed that I had added such a check further below, which indeed we have in there.
@ChSonnabend : Could you comment how it failed for you, and why my check below does not work:

echo "FMQ SHM files left which cannot be deleted, please clean up!"

@ChSonnabend
Copy link
Collaborator

This was added by @ChSonnabend , since he said the test failed for him due to existing files. Actually I did not check back then, even though I supposed that I had added such a check further below, which indeed we have in there. @ChSonnabend : Could you comment how it failed for you, and why my check below does not work:

echo "FMQ SHM files left which cannot be deleted, please clean up!"

Not sure anymore. I remember having some issues otherwise I wouldn't have added it. Fine for me if we comment it out and see if the issue reappears

@ehellbar
Copy link
Collaborator Author

for me, the original check works. Keep in mind that you will not see the existing shm segments when you are in a slurm shell, so when running in a slurm shell and checking for existing segments in a ssh shell, it might lead to wrong conclusions.

@ChSonnabend
Copy link
Collaborator

for me, the original check works. Keep in mind that you will not see the existing shm segments when you are in a slurm shell, so when running in a slurm shell and checking for existing segments in a ssh shell, it might lead to wrong conclusions.

Yes that's clear. Ok if the old check works then you can remove my check.

@ehellbar ehellbar merged commit 5768b11 into AliceO2Group:dev Mar 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants