feat(cc_so_import): allow cascade of sol linking #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a controversial feature, that should be use sparingly - setting 'cascade' flag to True on the 'cc_so_import' target, will result in propagation of the imported library upwards the dependency tree - that is anything that will transitevly depend on the cc_so_import, will suddenly be linking directly against it.
This change-set removes the script, that automatically populates the examples/libuuid with appropriate version of libuuid.so in favor of having that small binary file (22K) checked in. This is done due to the issues of retaining the behavior while run in the BCR automated tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a controversial feature,
that should be use sparingly - setting 'cascade'
flag to True on the 'cc_so_import' target,
will result in propagation of the imported
library upwards the dependency tree - that is
anything that will transitevly depend on the
cc_so_import, will suddenly be linking
directly against it.