feat(hdrs_map): graceful handling of duplicates #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset modifies the behavior of the logic responsible for materialization of header files mappings - previously, if the mappings resulted in any duplicated file entries, the logic will error out on the built-in Bazel ctx.actions.declare_file call. With this changes, situations in which a duplicate entry might appear are detected and avoided, while user is receving a warning message. First definiton to materialize, wins. At the moment this behavior is enabled by default and non-configurable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset modifies the behavior of the
logic responsible for materialization of header
files mappings - previously, if the mappings
resulted in any duplicated file entries, the
logic will error out on the built-in Bazel
ctx.actions.declare_file call.
With this changes, situations in which a duplicate entry might appear are detected and avoided,
while user is receving a warning message. First
definiton to materialize, wins.
At the moment this behavior is enabled by default
and non-configurable.