Update to latest QA tests (v1.0.4) #864
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
We did the check specifically for rate limiting but not yet for blocked user IDs.
In c12ee52 we've changed that we check this flag after inspecting args of an instrumented function For HTTP clients this means that we'll still call `agent.onConnectHostname(url.hostname, port);` And `agent.getConfig().shouldBlockOutgoingRequest(url.hostname)` too Blocking of new outbound connections should always work, doesn't matter if the route protection was disabled
So that `onRequest` will always be called Mistake in f22feb8
| `Your IP address is not allowed to access this resource. (Your IP: 1.3.2.2)` | ||
| ); | ||
| t.same(resp3.status, 200); | ||
| t.match(await resp3.text(), "Admin panel"); |
Member
There was a problem hiding this comment.
So https://github.com/AikidoSec/zen-specs/pull/7/changes is obsolete? I still think it is confusing 😅
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Aikido
⚡ Enhancements
🔧 Refactors