Fix musl detection & add smoke tests #234
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| return fileName.toString(); | ||
| } | ||
|
|
||
| public interface Libc { |
There was a problem hiding this comment.
GetBinaryPath now includes an FFI Libc interface and native probing, mixing path-construction and native-detection responsibilities.
Feedback
Post a comment with the following structure to provide feedback on this finding:
@AikidoSec feedback: [FEEDBACK]
Aikido will process this feedback into learnings to give better review comments in the future.
More info
There was a problem hiding this comment.
the path construction requires knowledge of musl vs gnu, would be strange to put it in another file, file name could be reworked I guess
| } | ||
| } catch (IOException e) { | ||
| logger.trace(e); | ||
| Libc.INSTANCE.gnu_get_libc_version(); |
There was a problem hiding this comment.
getLibCVariant calls gnu_get_libc_version() and discards its result, making the function's intent (probing for glibc) unclear.
Feedback
Post a comment with the following structure to provide feedback on this finding:
@AikidoSec feedback: [FEEDBACK]
Aikido will process this feedback into learnings to give better review comments in the future.
More info
There was a problem hiding this comment.
context of file seems enough to me?
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| on: | ||
| push: | ||
| branches: | ||
| - main |
There was a problem hiding this comment.
would remove this restriction? let's always run it?
There was a problem hiding this comment.
it runs for every PR, same as other workflows atm
No description provided.