-
Notifications
You must be signed in to change notification settings - Fork 41
Improve Readme #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Readme #917
Conversation
Summary of ChangesHello @descorp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the README by modernizing code snippets, improving the structure with a table of contents and collapsible sections, and enhancing readability. The changes make the documentation much more user-friendly and up-to-date.
My review includes a few suggestions to further improve consistency and correctness:
- Using consistent heading levels for all top-level sections.
- Ensuring code snippets follow best practices and are correct, such as passing the correct parameters in lifecycle methods.
- Maintaining consistent formatting for lists throughout the document.
Overall, this is a great update to the documentation.
Updated instructions for iOS and Android setup to correct terminology and improve clarity.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the README.md by modernizing code snippets to Swift and Kotlin, restructuring the content for better navigation with a Table of Contents and collapsible sections, and enhancing readability. The changes make the documentation much more user-friendly and up-to-date.
I've found a couple of critical issues that need attention: a typo in a Swift code snippet in the README and the removal of a necessary method from the Android example app, which contradicts the documentation. Please see my detailed comments.
I am having trouble creating individual review comments. Click here to see my feedback.
README.md (132)
There is a typo in the Swift code snippet. retrurn should be return. This is important to fix as developers will likely copy and paste this code for their integration.
return RedirectComponent.applicationDidOpen(from: url)
example/android/app/src/main/java/com/adyenexample/MainActivity.kt (36-43)
The onActivityResult method has been removed from the example's MainActivity.kt. However, the updated README.md still instructs users to add this method for Google Pay integration. Removing it from the example app could break Google Pay functionality and will cause confusion for developers using the example as a reference. Please restore this method to keep the example app consistent with the documentation.
|



Changes
Code Modernization
Structure Improvements
Details
blocks for iOS and Android setup sectionsReadability Improvements
New Addition