Skip to content

Conversation

@descorp
Copy link
Contributor

@descorp descorp commented Jan 23, 2026

Changes

Code Modernization

  • Objective-C → Swift: All iOS code snippets converted to Swift
  • Java → Kotlin: All Android code snippets converted to Kotlin

Structure Improvements

  • Added Table of Contents for quick navigation
  • Moved Contributing section to bottom (follows standard convention)
  • Consolidated Expo sections into one with collapsible plugin configuration
  • Added collapsible
    Details blocks for iOS and Android setup sections

Readability Improvements

  • Fixed inconsistent code indentation in Sessions/Advanced flow examples
  • Cleaner callback comments with concise single-line format
  • Updated GitHub alert syntax (> [!NOTE], > [!TIP])
  • Added direct link to create GitHub issues in Support section
  • Added link to LICENSE file

New Addition

  • Legacy Objective-C link in iOS Setup for merchants still using Obj-C

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @descorp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the README.md file by modernizing code examples to Swift and Kotlin, improving the overall structure with a new Table of Contents and collapsible sections, and boosting readability through consistent formatting and clearer explanations. The changes aim to make the documentation more accessible, up-to-date, and user-friendly for developers integrating the Adyen React Native SDK.

Highlights

  • Code Modernization: All iOS code snippets have been converted from Objective-C to Swift, and all Android code snippets have been converted from Java to Kotlin, ensuring the documentation reflects modern development practices.
  • Structure Improvements: A Table of Contents has been added for quick navigation. The 'Contributing' section has been moved to the bottom, and Expo sections are consolidated with collapsible plugin configuration. Collapsible
    Details blocks are now used for iOS and Android setup sections to improve readability and organization.
  • Readability Enhancements: Inconsistent code indentation in Sessions/Advanced flow examples has been fixed. Callback comments are now cleaner and more concise. GitHub alert syntax has been updated, and direct links to create GitHub issues and the LICENSE file have been added.
  • Legacy Support: A direct link to legacy Objective-C documentation has been included in the iOS Setup section for merchants still using Objective-C.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the README by modernizing code snippets, improving the structure with a table of contents and collapsible sections, and enhancing readability. The changes make the documentation much more user-friendly and up-to-date.

My review includes a few suggestions to further improve consistency and correctness:

  • Using consistent heading levels for all top-level sections.
  • Ensuring code snippets follow best practices and are correct, such as passing the correct parameters in lifecycle methods.
  • Maintaining consistent formatting for lists throughout the document.

Overall, this is a great update to the documentation.

descorp and others added 5 commits January 26, 2026 15:10
Updated instructions for iOS and Android setup to correct terminology and improve clarity.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@descorp
Copy link
Contributor Author

descorp commented Jan 26, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the README.md by modernizing code snippets to Swift and Kotlin, restructuring the content for better navigation with a Table of Contents and collapsible sections, and enhancing readability. The changes make the documentation much more user-friendly and up-to-date.

I've found a couple of critical issues that need attention: a typo in a Swift code snippet in the README and the removal of a necessary method from the Android example app, which contradicts the documentation. Please see my detailed comments.

I am having trouble creating individual review comments. Click here to see my feedback.

README.md (132)

critical

There is a typo in the Swift code snippet. retrurn should be return. This is important to fix as developers will likely copy and paste this code for their integration.

    return RedirectComponent.applicationDidOpen(from: url)

example/android/app/src/main/java/com/adyenexample/MainActivity.kt (36-43)

critical

The onActivityResult method has been removed from the example's MainActivity.kt. However, the updated README.md still instructs users to add this method for Google Pay integration. Removing it from the example app could break Google Pay functionality and will cause confusion for developers using the example as a reference. Please restore this method to keep the example app consistent with the documentation.

@sonarqubecloud
Copy link

@descorp descorp merged commit a88cc8e into develop Jan 26, 2026
9 checks passed
@descorp descorp deleted the readme-2.0 branch January 26, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants