Improve invalid client key error handling

[descorp]

Changes

Functional

• add validation for clientKey
• remap empty API response into "Invalid Client Key" error
  • BaseModule now remap error before sending event
  • SessionHelperModule remap before rejecting
  • ActionModule remap before rejecting

Internal

• move NativeModuleError to a standalone file
• code cleanup with swiftlint

Before	After

[gemini-code-assist]

Summary of Changes

Hello @descorp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the error handling mechanisms within the iOS modules, particularly focusing on client key validation and the clarity of error messages. By centralizing error definitions and their processing, the changes aim to provide more precise and actionable feedback, especially when dealing with invalid client keys or empty API responses, thereby improving the overall robustness and maintainability of the codebase.

Highlights

• Enhanced Client Key Validation: Introduced explicit validation for the clientKey during context fetching, throwing a specific invalidClientKey error if the key is found to be invalid.
• Centralized Error Handling: The NativeModuleError enum and its associated error checking logic (checkErrorType) have been extracted into a dedicated file (NativeModuleError.swift) for better organization and reusability across modules.
• Improved Error Mapping: Empty API responses are now explicitly remapped to an invalidClientKey error, providing clearer and more specific feedback for certain network issues.
• Refactored Error Rejection: Simplified error rejection mechanisms across modules, consolidating error handling logic and reducing redundancy by introducing a generic reject(with: any Error) function.
• Code Formatting and Cleanup: Applied minor formatting adjustments across several files, likely as a result of code style enforcement, improving overall readability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves error handling, particularly for invalid client keys. It introduces upfront validation for the client key and correctly remaps empty API responses to a specific "Invalid Client Key" error. The code is also cleaner due to moving the NativeModuleError enum to its own file and applying swiftlint for formatting consistency. The changes are well-structured. I have one suggestion to make the error reporting in the session creation flow more specific and consistent.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[erenbesel]

approved but one question