Skip to content

Conversation

@ozgur00
Copy link
Contributor

@ozgur00 ozgur00 commented Jan 15, 2026

Description

This PR implements alignment decisions for Card Configuration. The fields still needing to be determined are not included.

Checklist

  • Changes are tested manually

COSDK-792

@ozgur00 ozgur00 requested a review from a team as a code owner January 15, 2026 13:16
@AdyenAutomationBot AdyenAutomationBot added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Jan 15, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ozgur00, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the card configuration options to use a more generic FieldMode enum for controlling the visibility of specific fields, specifically Social Security Number and KCP authentication. This change aims to provide a more consistent and maintainable approach to managing field visibility across the card component.

Highlights

  • Card Configuration Alignment: This PR focuses on aligning the Card Configuration by introducing FieldMode enum to manage the visibility of Social Security Number and KCP authentication fields.
  • FieldMode Enum: Replaces SocialSecurityNumberVisibility and KCPAuthVisibility enums with a unified FieldMode enum for showing or hiding fields.
  • Configuration Updates: Updates CardConfiguration and CardConfigurationBuilder to use FieldMode for Social Security Number and KCP authentication visibility settings.
  • Parameter Mapping: Adjusts CardComponentParamsMapper to map the new FieldMode settings to the component parameters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the card configuration to align property names and consolidate visibility enums into a single FieldMode enum. This is a good step towards consistency. My review focuses on a few remaining inconsistencies in property naming within CardConfigurationBuilder and the internal CardComponentParams class. Addressing these would further improve the alignment and clarity of the configuration API.

@ozgur00 ozgur00 force-pushed the chore/card-configuration-alignment branch from ab7f7d5 to 0c8a12f Compare January 16, 2026 12:10
@github-actions
Copy link
Contributor

✅ No public API changes

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ozgur00 ozgur00 added this pull request to the merge queue Jan 19, 2026
Merged via the queue into main with commit ed4a986 Jan 19, 2026
10 of 11 checks passed
@ozgur00 ozgur00 deleted the chore/card-configuration-alignment branch January 19, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes size:tiny

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants