Skip to content

Conversation

@deancureton
Copy link

@deancureton deancureton commented Jan 31, 2026

Just adding Helium (https://helium.computer, https://github.com/imputnet/helium) to the browser list. It's Chromium-based so this is the only change needed to get it working well in the web UI. Thanks!!


Important

Add Helium to browser_appnames in src/queries.ts to support Helium browser events.

  • Behavior:
    • Add Helium to browser_appnames in src/queries.ts to support Helium browser events.
    • Recognizes Helium as a Chromium-based browser for web UI functionality.

This description was created by Ellipsis for 7ca67ac. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 7ca67ac in 5 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_gMRCLKVW512Wewmr

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 31, 2026

Greptile Overview

Greptile Summary

This PR updates src/queries.ts to recognize the Helium browser by adding its app/window identifiers to browser_appnames. This enables the existing browser-event query logic (which filters window events by known browser app names and merges in browser URL activity) to treat Helium as a Chromium-based browser without further changes elsewhere in the web UI.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • The change is a small, additive update to a static allowlist of browser application names; it does not affect query generation logic beyond enabling Helium matching.
  • No files require special attention

Important Files Changed

Filename Overview
src/queries.ts Adds Helium identifiers to the browser_appnames list so Helium window events are treated as browser activity.

Sequence Diagram

sequenceDiagram
  participant UI as aw-webui
  participant AW as ActivityWatch server

  UI->>AW: query available buckets (aw-client)
  AW-->>UI: list of bucketIds
  UI->>UI: browsersWithBuckets() maps known browsers to bucketIds
  UI->>AW: canonicalEvents() / fullDesktopQuery() includes browserEvents()
  AW-->>UI: window events + browser_events
  UI->>UI: filter window events by browser_appnames[helium]
  UI-->>UI: Helium window activity counted as browser activity
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.08%. Comparing base (435be30) to head (7ca67ac).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #744   +/-   ##
=======================================
  Coverage   26.08%   26.08%           
=======================================
  Files          29       29           
  Lines        1698     1698           
  Branches      294      294           
=======================================
  Hits          443      443           
  Misses       1233     1233           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant