-
-
Notifications
You must be signed in to change notification settings - Fork 138
fix: add Helium to browser list #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 7ca67ac in 5 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_gMRCLKVW512Wewmr
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Greptile OverviewGreptile SummaryThis PR updates Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant UI as aw-webui
participant AW as ActivityWatch server
UI->>AW: query available buckets (aw-client)
AW-->>UI: list of bucketIds
UI->>UI: browsersWithBuckets() maps known browsers to bucketIds
UI->>AW: canonicalEvents() / fullDesktopQuery() includes browserEvents()
AW-->>UI: window events + browser_events
UI->>UI: filter window events by browser_appnames[helium]
UI-->>UI: Helium window activity counted as browser activity
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
=======================================
Coverage 26.08% 26.08%
=======================================
Files 29 29
Lines 1698 1698
Branches 294 294
=======================================
Hits 443 443
Misses 1233 1233
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just adding Helium (https://helium.computer, https://github.com/imputnet/helium) to the browser list. It's Chromium-based so this is the only change needed to get it working well in the web UI. Thanks!!
Important
Add Helium to
browser_appnamesinsrc/queries.tsto support Helium browser events.browser_appnamesinsrc/queries.tsto support Helium browser events.This description was created by
for 7ca67ac. You can customize this summary. It will automatically update as commits are pushed.