Merged
Conversation
Closed
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
JaCoCo code coverage report - scala 2.12.17
|
JaCoCo code coverage report - scala 2.11.12
|
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the repository in preparation for open source development by updating documentation, workflows, and project structure.
- Added various documentation files including CONTRIBUTING, LICENSE, and issue templates.
- Updated YAML workflows for release, CI, and CD while removing Aquasec steps.
- Renamed the package from "africa.absa" to "za.co.absa" and adjusted related documentation accordingly.
Reviewed Changes
Copilot reviewed 47 out of 53 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| bigfiles/README.md | Updated package reference and modified configuration placeholders. |
| README.md | Added an "Abstract example" section and fixed a typo in bullet points. |
| CONTIBUTING.md | Introduced new contributing guidelines (note filename spelling). |
| .github/workflows/*.yml | Added and modified multiple workflows for release, CI & CD. |
| .github/ISSUE_TEMPLATE/*.md | Added new issue templates for spike, bug, feature, epic, and operative tasks. |
Files not reviewed (6)
- LICENSE: Language not supported
- bigfiles/build.sbt: Language not supported
- bigfiles/project/Dependencies.scala: Language not supported
- bigfiles/project/plugins.sbt: Language not supported
- bigfiles/src/main/scala/africa/absa/cps/analysis/ColumnsDiff.scala: Language not supported
- bigfiles/src/main/scala/africa/absa/cps/analysis/RowsDiff.scala: Language not supported
| @@ -0,0 +1,36 @@ | |||
| # How to Contribute? | |||
There was a problem hiding this comment.
The file name 'CONTIBUTING.md' appears to be misspelled; consider renaming it to 'CONTRIBUTING.md' to align with common conventions.
Comment on lines
+58
to
+59
| cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}$base_name | ||
| echo "artifact_name=scala-${{ matrix.scalaShort }}$base_name" >> $GITHUB_ENV |
There was a problem hiding this comment.
[nitpick] Consider adding a separator between '${{ matrix.scalaShort }}' and '$base_name' (e.g., using a dash) to improve the clarity of the artifact name.
Suggested change
| cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}$base_name | |
| echo "artifact_name=scala-${{ matrix.scalaShort }}$base_name" >> $GITHUB_ENV | |
| cp target/scala-${{ matrix.scalaShort }}/dataset-comparison-*.jar staging/scala-${{ matrix.scalaShort }}-$base_name | |
| echo "artifact_name=scala-${{ matrix.scalaShort }}-$base_name" >> $GITHUB_ENV |
ABMC831
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entire repository was cleaned up and prepared for development as open source.
Release notes:
africa.absatoza.co.absaCloses #1