Open
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the documentation and refactors the Scala codebase for the big file comparison project. The changes clarify the modular structure, update instructions for running and testing, and introduce new, well-documented types for comparison logic. The code is reorganized into
apiandappmodules, with clearer separation of concerns and enhanced type safety for analysis results and metrics.Documentation improvements:
README.md, explaining the split intoapiandappmodules and listing key files and their responsibilities. Updated all example commands and configuration paths to reflect the new structure and module separation. [1] [2] [3] [4]Codebase modularization and refactoring:
apimodule (Comparator.scala,DatasetComparisonHelper.scala,analysis/*), separating them from CLI and I/O code in theappmodule. [1] [2]DatasetComparisonHelper.excludeto remove unnecessarySparkSessionparameter, simplifying its interface.Typed analysis and metrics:
AnalysisResultand its case classes to represent explicit outcomes of row-by-row analysis, improving error handling and result clarity. [1] [2]ComparisonMetricscase class for comparison statistics, and a default implementation ofComparisonMetricsCalculatorthat computes metrics for any dataset pair. [1] [2]API documentation and code comments:
Overview
Release Notes
Related
Closes #14