Skip to content

[Bugfix] Fix infinite loop in TranslationTask #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TylerS1066 merged 8 commits into from
Mar 16, 2025
Merged

[Bugfix] Fix infinite loop in TranslationTask #741

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d3e3278
fix infinite loop and missing return
DerToaster98 Dec 8, 2024
fb79828
fix build error (missing semicolon)
DerToaster98 Dec 8, 2024
b4a5737
add translation
DerToaster98 Dec 8, 2024
6515aba
change loop condition instead
DerToaster98 Dec 14, 2024
05e0a8b
dont check max y
DerToaster98 Dec 30, 2024
c06724a
Merge pull request #22 from APDevTeam/main
DerToaster98 Feb 12, 2025
7849a2c
Merge branch 'main' into pr/721
TylerS1066 Mar 16, 2025
6838678
Clean up
TylerS1066 Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Movecraft/src/main/java/net/countercraft/movecraft/async/translation/TranslationTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,15 @@ protected void execute() throws InterruptedException, ExecutionException {
MovecraftLocation test = new MovecraftLocation(newHitBox.getMidPoint().getX(), newHitBox.getMinY(),
newHitBox.getMidPoint().getZ());
test = test.translate(0, -1, 0);
while (test.toBukkit(world).getBlock().getType().isAir()) {
// If we are out of bounds, that is technically air, but then we would have an infinite loop, so stay in Y bounds
while (test.toBukkit(world).getBlock().getType().isAir() && world.getMinHeight() >= test.getY()) {
test = test.translate(0, -1, 0);
}
Material testType = test.toBukkit(world).getBlock().getType();
if (craft.getType().getMaterialSetProperty(CraftType.FORBIDDEN_HOVER_OVER_BLOCKS).contains(testType)) {
fail(String.format(I18nSupport.getInternationalisedString("Translation - Failed Craft over block"),
testType.name().toLowerCase().replace("_", " ")));
return;
}
}
//call event
Expand Down