Reuse already calculated tags #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Put a comment in here once you've tested the PR and I'll take a look. |
TylerS1066
approved these changes
Mar 16, 2025
Contributor
|
Confirmed to be functional, good addition to #674. In the future please test your own PRs before marking them ready (drafts are fine). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
We already calculated Flyblocks and Moveblocks counters in the StatusManager's supplier, let's reuse their calculation (which was saved in the craft's data tags FLYBLOCKS and MOVEBLOCKS) instead of recalculating it from the MATERIALS tag.
Checklist