[Fix] Correct piston merge related logic #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve TrackedLocation (APDevTeam#727)
(cherry picked from commit f2cab65)
Contributor
|
Put a comment in here once you've tested the PR and I'll take a look. |
Contributor
Author
|
Tested it just now. Blocks pulled and pushed by pistons are added to the craft's hitbox Overall thing that would be good in movecraft would be using dynamic connectivity to avoid things like crafts that have been shot in half still being technically the same thing. |
TylerS1066
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail what your pull request accomplishes
Fixes the inverted logic in the event handler.
Since both retract and extend calls that method, it should do something for either case, so remove the instanceof check for the Extend event and instead use a list.
Checklist