Add more CI for the oldest supported CMake#3096
Open
vrabaud wants to merge 1 commit intoAOMediaCodec:mainfrom
Open
Add more CI for the oldest supported CMake#3096vrabaud wants to merge 1 commit intoAOMediaCodec:mainfrom
vrabaud wants to merge 1 commit intoAOMediaCodec:mainfrom
Conversation
vrabaud
changed the title
y-guyon
approved these changes
Mar 11, 2026
wantehchang
reviewed
Mar 11, 2026
wantehchang
reviewed
Mar 11, 2026
wantehchang
reviewed
Mar 11, 2026
wantehchang
reviewed
Mar 11, 2026
wantehchang
reviewed
Mar 11, 2026
Fix CMake code to work with CMake 3.22. Fixes AOMediaCodec#3095
wantehchang
approved these changes
Mar 12, 2026
| - uses: ./.github/actions/setup-linux | ||
| with: | ||
| codec-aom: "LOCAL" | ||
| codec-dav1d: "LOCAL" |
Collaborator
There was a problem hiding this comment.
Just wanted to confirm that there is no codec-libgav1 variable, so we don't need to add codec-libgav1: "LOCAL".
| -DAVIF_CODEC_SVT=LOCAL | ||
| -DAVIF_JPEG=LOCAL -DAVIF_LIBSHARPYUV=LOCAL | ||
| -DAVIF_LIBXML2=LOCAL -DAVIF_LIBYUV=LOCAL | ||
| -DAVIF_ZLIBPNG=LOCAL |
Collaborator
There was a problem hiding this comment.
I guess the goal of this CI workflow is to use LOCAL for all dependencies?
Collaborator
|
Nit: I suggest using "Fix build with CMake 3.22" as the title of the commit message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And fix the resulting bugs.