Update constraint_set schema to allow manufacturer namespaces#31
Merged
cristian-recoseanu merged 4 commits intov1.0.xfrom Jul 30, 2025
Merged
Update constraint_set schema to allow manufacturer namespaces#31cristian-recoseanu merged 4 commits intov1.0.xfrom
cristian-recoseanu merged 4 commits intov1.0.xfrom
Conversation
to allow manufacturer namespaces
garethsb
approved these changes
Jun 4, 2025
Contributor
garethsb
left a comment
garethsb
left a comment
There was a problem hiding this comment.
LGTM.
Noting that the regex ^urn:[a-z0-9][a-z0-9-]{0,30}[a-z0-9]: is based on RFC 8141 definition of NID (but we stick to allowing lowercase only):
assigned-name = "urn" ":" NID ":" NSS
NID = (alphanum) 0*30(ldh) (alphanum)
ldh = alphanum / "-"
|
Note that IS-11 APIs/schemas/constraint_set.json and APIs/schemas/constraints_supported.json should also be modified to support the stricter RFC 8141 definition but there is no harm in keeping IS-11 more "generic". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.