Skip to content

Conversation

@zingale
Copy link
Member

@zingale zingale commented Dec 14, 2025

this will change answers to roundoff because we do sqrt(sqrt(x)) instead of pow(x, 0.25)

@zingale
Copy link
Member Author

zingale commented Dec 16, 2025

here are the tests:
http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2025-12-16-001/index.html

if you look at the screening test, you can see that the sqrt(sqrt(x)) change introduces roundoff diffs.

http://groot.astro.sunysb.edu/Microphysics/test-suite/gfortran/2025-12-16-001/test_screening_C.html

For a few tests, the burning takes an additional few steps, giving seemingly large diffs in the output. But I think that the diffs are okay.

We might be able to write our own qdrt() function that does the automatic differentiation more efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant