-
Notifications
You must be signed in to change notification settings - Fork 6
Add RTDE driver configuration and UUID to edge.yaml and uuids.js #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTDE driver configuration and UUID to edge.yaml and uuids.js #570
Conversation
|
@Harrier-SA Are you able to set up commit signing? We have set this repo to require signed commits for better traceability. We mostly use SSH keys for signing as it's easier. To set this up you need to do this:
|
@Harrier-SA it also might be worth not pulling the latest changes from remote before you do this. I accidentally updated this branch, but if you |
This makes more sense given the behaviour of the underlying library.
…dling - Added `driver-passwords` and `scripts/` to .gitignore - Created LOCAL_DEVELOPMENT.md for Edge Agent setup instructions - Refactored driver.js and rtde.js for improved connection handling and data parsing - Updated async.js to enhance data logging logic - Bumped edge-driver version to 0.0.5 in package-lock.json -Tested with Factory+ instance and achieved succesful data flow.
Undo changes to lib/js-edge-driver/lib/driver.js and edge-rtde/lib/rtde.js.
a5772c7 to
20430a0
Compare
|
@amrc-benmorrow @AlexGodbehere Thanks for the advice on getting this set-up I believe I have now done it and rebased the changes to include the commit signing. |
amrc-benmorrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here are correct; the history is now a bit of a mess because I pressed the wrong button on the GH UI and I can't now undo it. Some of the commits are now duplicated in signed and unsigned versions, but it doesn't really matter.
|
@Harrier-SA Version v4.3.2 is now building: https://github.com/AMRC-FactoryPlus/amrc-connectivity-stack/actions/runs/18713980030 |
This pull request adds support for a new RTDE driver to the ACS service setup. The main changes include registering the RTDE driver, defining its configuration schema and presentation details, and assigning it a unique UUID.
RTDE Driver Integration:
ACS.Driver.RTDEobject inedge.yamlto enable RTDE driver support.ACS.Driver.RTDEinedge.yaml, including connection details (host,port), presentation fields (address,path), and descriptions for available metric addresses and JSONPath usage.Identifiers and Metadata:
ACS.Driver.RTDEinlib/uuids.jsto ensure proper identification and referencing throughout the system.