Skip to content

Add customizable binaries support#1085

Merged
scaliby merged 1 commit intoAI-Hypercomputer:mainfrom
scaliby:customizable-binaries
Feb 27, 2026
Merged

Add customizable binaries support#1085
scaliby merged 1 commit intoAI-Hypercomputer:mainfrom
scaliby:customizable-binaries

Conversation

@scaliby
Copy link
Member

@scaliby scaliby commented Feb 27, 2026

Description

Add customizable binaries support

Issue

b/487987761

Testing

Tested manually in my terminal.

@scaliby scaliby added the release-features features label Feb 27, 2026
@scaliby scaliby marked this pull request as ready for review February 27, 2026 13:19
Copy link
Collaborator

@jamOne- jamOne- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about this Gemini review:

  1. Handle Path Expansion (High Impact):
     Shell-specific variables (like $HOME) and tildes (~) are frequently used in
  configuration files for paths, but they are not automatically expanded when subprocess
  searches PATH.
      * Fix: Apply os.path.expanduser and os.path.expandvars to the custom_binaries_path
        before prepending it to os.environ['PATH']. If users specify multiple custom paths
        separated by os.pathsep (e.g., :), split, expand each part, and rejoin them.

@scaliby
Copy link
Member Author

scaliby commented Feb 27, 2026

WDYT about this Gemini review:

  1. Handle Path Expansion (High Impact):
     Shell-specific variables (like $HOME) and tildes (~) are frequently used in
  configuration files for paths, but they are not automatically expanded when subprocess
  searches PATH.
      * Fix: Apply os.path.expanduser and os.path.expandvars to the custom_binaries_path
        before prepending it to os.environ['PATH']. If users specify multiple custom paths
        separated by os.pathsep (e.g., :), split, expand each part, and rejoin them.

The expansion works when you set the flag. In fact I tried to override bins with this command:

xpk config set custom-binaries-path $PWD/bin_test

Which set the following property in config:

version: v1
configs:
  client-id: XXX
  custom-binaries-path: /home/scaliby/xpk/bin_test

So the expansion happened at the bash execution time, when setting the property. Do we need to do it as well at runtime?
@jamOne- WDYT?

@jamOne-
Copy link
Collaborator

jamOne- commented Feb 27, 2026

Right, lgtm. Thanks for checking

@scaliby scaliby added this pull request to the merge queue Feb 27, 2026
Merged via the queue into AI-Hypercomputer:main with commit d09a1da Feb 27, 2026
29 checks passed
@scaliby scaliby deleted the customizable-binaries branch February 27, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants