Add customizable binaries support#1085
Merged
scaliby merged 1 commit intoAI-Hypercomputer:mainfrom Feb 27, 2026
Merged
Conversation
SikaGrr
approved these changes
Feb 27, 2026
jamOne-
approved these changes
Feb 27, 2026
Collaborator
jamOne-
left a comment
There was a problem hiding this comment.
WDYT about this Gemini review:
1. Handle Path Expansion (High Impact):
Shell-specific variables (like $HOME) and tildes (~) are frequently used in
configuration files for paths, but they are not automatically expanded when subprocess
searches PATH.
* Fix: Apply os.path.expanduser and os.path.expandvars to the custom_binaries_path
before prepending it to os.environ['PATH']. If users specify multiple custom paths
separated by os.pathsep (e.g., :), split, expand each part, and rejoin them.
Member
Author
The expansion works when you set the flag. In fact I tried to override bins with this command: xpk config set custom-binaries-path $PWD/bin_testWhich set the following property in config: version: v1
configs:
client-id: XXX
custom-binaries-path: /home/scaliby/xpk/bin_testSo the expansion happened at the bash execution time, when setting the property. Do we need to do it as well at runtime? |
Collaborator
|
Right, lgtm. Thanks for checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add customizable binaries support
Issue
b/487987761
Testing
Tested manually in my terminal.