Small refactor of gmm in moe.py#3605
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 10, 2026
Merged
Conversation
gobbleturk
requested review from
RissyRan,
gagika,
jesselu-google,
michelle-yooh,
richjames0,
shralex and
suexu1025
as code owners
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
gobbleturk
requested review from
A9isha,
NicoGrande,
NuojCheng,
SurbhiJainUSC,
aireenmei,
bvandermoon,
dipannita08,
hengtaoguo,
igorts-git,
jiangjy1982,
khatwanimohit and
vipannalla
as code owners
|
🤖 Hi @RissyRan, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
🤖 I'm sorry @RissyRan, but I was unable to process your request. Please see the logs for more details. |
RissyRan
reviewed
Apr 9, 2026
| group_sizes, | ||
| max_utils.generate_representative_group_sizes(inputs.shape[0], kernel.shape[0]), | ||
| ) | ||
| pad_length = self.config.wi_tile_fwd_batch_seq |
Collaborator
There was a problem hiding this comment.
Are those padding also considered in the refactor? I didn't find them.
Collaborator
Author
There was a problem hiding this comment.
ya padding is done here https://screenshot.googleplex.com/6G9rrNgnnYwmpQ9
richjames0
approved these changes
Apr 9, 2026
Collaborator
richjames0
left a comment
richjames0
left a comment
There was a problem hiding this comment.
lgtm pending ran's comment
gobbleturk
force-pushed
the
mattdavidow-gmm-clean-a1
branch
from
8c18ad4 to
feb61fc
Compare
RissyRan
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small refactor to help aide in code readability/maintainability following go/small-functions
I should probably have used an agent for this, but manually doing this has forced me to learn our code. Understanding is the way!
Tests
Identical performance before/after (pure refactor)
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.