Added rough grainstats summary documentation and metric images #1087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 5, 2025 14:56
Max-Gamill
commented
Feb 5, 2025
re-add ` `
Max-Gamill
commented
Feb 11, 2025
Max-Gamill
commented
Feb 11, 2025
SylviaWhittle
approved these changes
Feb 11, 2025
Collaborator
SylviaWhittle
left a comment
SylviaWhittle
left a comment
There was a problem hiding this comment.
Given it a read and it all makes sense to me. Absolutely lovely visual explanations!
ns-rse
requested changes
Feb 14, 2025
Collaborator
ns-rse
left a comment
ns-rse
left a comment
There was a problem hiding this comment.
Thanks for all the hard work on this @MaxGamill-Sheffield it looks really good once rendered locally. 👍 🎨
One minor suggestion of including min_feret and max_feret in the GrainStats diagram.
ns-rse
reviewed
Feb 24, 2025
Collaborator
Author
|
Thanks for pointing this out @ns-rse. Note from catchup: The Ferets do not have to be orthogonal and so are different to the min bounding length / widths |
ns-rse
approved these changes
Feb 27, 2025
Collaborator
ns-rse
left a comment
ns-rse
left a comment
There was a problem hiding this comment.
Thanks for adding the feret schematic and expanding the description, good to merge 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TopoStats Pull Requests
This adds my thesis diagrams for visualisation of the metrics output by TopoStats into the documentation.
It also includes a previously missing "grainstats" section.