Reintroduce Dexter rhoV with grtrans mitigation #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analogous to grtrans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotativity solutions for transport should correctly recover the low-temperature (non-relativistic) solution for Faraday rotation. However, there are various ways of transitioning from a fit designed to be broadly applicable down to the low-T limit.
This exists because for the polarized comparison, I wanted to directly compare low-temperature rotativity behavior from various codes.
grtrans, for example, generally uses the fits outlined in thegrtranspaper -- however, it has a somewhat interesting 3-part smooth transition to the non-relativistic limit, whichipoledid not originally capture when using these functions.Since it now behaves well (and quite similarly overall to the default Shcherbakov fit), this PR re-introduces the Dexter rhoV fit as a runtime option (previously, it could not be enabled at all). Basically, I found it lying around in a testing branch and figured it might be a net benefit to have upstream as a reference or comparison option.