Skip to content

Conversation

@AanviKothari456
Copy link

Jira Ticket

Jira Ticket

Description

Center and resize the CM.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Changes

Testing

Tested on localhost.

Checklist

  • My branch name matches the format: <ticket-id>/<brief-description-of-change>
  • My PR name matches the format: [<ticket-id>] <brief-description-of-change>
  • I have added doc-comments to all new functions (JSDoc for JS and Docstrings for Python)
  • I have reviewed all of my code
  • My code only contains major changes related to my ticket

Screenshots/Video

Additional Notes

@Connor-Bernard Connor-Bernard requested review from Connor-Bernard and naveen-nathan and removed request for Connor-Bernard November 23, 2024 00:13
@Connor-Bernard
Copy link
Member

Sorry this should be reviewed by CM team not GV (I shouldn't have marked myself as a reviewer)

Copy link
Contributor

@naveen-nathan naveen-nathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dan commented on the CM this PR produces. Dan’s ask needs to be addressed (screenshot attached).

CM23Ask

@naveen-nathan
Copy link
Contributor

naveen-nathan commented Feb 20, 2025

Hi @AFA-Tooling/concept-map . A note about CM-23:

This issue is more complicated than it appears. I recommend that the CM team work on it collectively rather than individually.

@Connor-Bernard
Copy link
Member

Happy to look into this again -- would you be able to make sure this branch is up to date and then send screenshots of how this looks through the portal?

@naveen-nathan
Copy link
Contributor

naveen-nathan commented Mar 3, 2025

Happy to look into this again -- would you be able to make sure this branch is up to date and then send screenshots of how this looks through the portal?

Hi Connor. Thank you! This was not my ticket, and I never worked on it; I only reviewed the PR. As such, I think it would be best if the current CM team does the needful.

@Connor-Bernard
Copy link
Member

Happy to look into this again -- would you be able to make sure this branch is up to date and then send screenshots of how this looks through the portal?

Hi Connor. Thank you! This was not my ticket, and I never worked on it; I only reviewed the PR. As such, I think it would be best if the current CM team does the needful.

Oh yeah no worries @naveen-nathan. That message was for @AanviKothari456.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants