Update for latest starfallex#35
Merged
Stooberton merged 2 commits intoACF-Team:masterfrom Feb 9, 2020
thegrb93:starfall
Merged
Update for latest starfallex#35Stooberton merged 2 commits intoACF-Team:masterfrom thegrb93:starfall
Stooberton merged 2 commits intoACF-Team:masterfrom
thegrb93:starfall
Conversation
Collaborator
|
Spawning ACF components is highly exploitable. I'd prefer if it were changed to have components default to a limit of 0 so server owners would have to knowingly enable it, similar to the cores in E2. |
Contributor
Author
|
Done, but a starfall bug is preventing the defaults from applying so I'll fix that first |
Contributor
Author
|
Fixed in thegrb93/StarfallEx@7c4709a |
Collaborator
|
Awesome. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from nrlulz/ACF#331 with a few additional fixes to work with acf-3.