Merged
Conversation
Member
Author
|
@edoyango Would you mind having a look at these? Most are trivial, but I would like someone to double check the change to the Cylc manager. |
micaeljtoliveira
force-pushed
the
several_fixes_and_improvements
branch
from
03d0f49 to
71f7b52
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 834 834
=========================================
Hits 834 834 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edoyango
requested changes
Feb 16, 2026
Collaborator
edoyango
left a comment
edoyango
left a comment
There was a problem hiding this comment.
mostly lgtm. Main concern is the use of filter keyword, which was introduced in python 3.12.
micaeljtoliveira
force-pushed
the
several_fixes_and_improvements
branch
from
71f7b52 to
74023f2
Compare
edoyango
approved these changes
Feb 17, 2026
…his requires Python >= 3.11.4.
…instead of calling them directly.
…rics", shadowing the parent's property. Also fixed the return type annotation from float to dict.
…lines() instead of split(). Adapt the test to fail when using split().
…are against correct_cylc_task_data instead of self-comparing data["region"]. This showed that there was a typo in the sample data used for the test.
micaeljtoliveira
force-pushed
the
several_fixes_and_improvements
branch
from
74023f2 to
162c669
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several issues flagged by feeding the code to Claude Opus.