Refactor functions that parse profiling data #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 782 791 +9
=========================================
+ Hits 782 791 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- replace the parse_profiling_data method with profiling_logs, a method that returns a dict of logs to be parsed - add a _parse_profiling_data_directory helper method to parse all the logs from a given experiment path - ProfilingLogs now have a "optional" property: when parsing optional logs, no error is returned if the file is missing or not data is parsed The PayuManager and CylcRoseManager are updated accordingly.
…nager. These seem generic enough to be move one level up.
micaeljtoliveira
force-pushed
the
refactor_parse_profiling_data
branch
from
f5d374c to
1460245
Compare
…data method. This new method stores the profiling data per experiment, without concatenatng the datasets. The scaling data is then computed on-the-fly when calling plot_scaling_data. - When computing the scaling data on-the-fly when, plot_scaling_data now takes care of filtering the components and regions, and of relabeling the regions. This in turn allows to simplify the plot_scaling_metrics function.
edoyango
reviewed
Jan 7, 2026
| logger.info(f"Parsing {log_name} profiling log: {log.filepath}. ") | ||
| if log.optional: | ||
| try: | ||
| self.data[exp_name][log_name] = log.parse() |
Collaborator
There was a problem hiding this comment.
probably want to include logger.info(" Done.") here for consistency with non-optional logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring of the manager code:
profiling_logs, a method that returns a dict of logs to be parsedProfilingLogsnow have a "optional" property: when parsing optional logs, no error is returned if the file is missing or not data is parsedparse_scaling_datawith a more genericparse_profiling_datamethod. This new method parses all the logs from all experiments, then stores the profiling data per experiment, without concatenating the datasets.plot_scaling_data.__init__andparse_ncpusmethods from RAM3Profiling toCylcRoseManager. These seem generic enough to be move one level up.