UM parser

[manodeep]

Continuing on with this

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.82%. Comparing base (eb94c1f) to head (56aa56a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   98.13%   98.82%   +0.69%     
==========================================
  Files           5        6       +1     
  Lines         107      170      +63     
==========================================
+ Hits          105      168      +63     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[micaeljtoliveira]

@manodeep Looks good, but I have to admit I didn't look too closely at the regex stuff. The units tests seems to show it works as intended and that's good enough for me :)

I just have one small, optional, suggestion.

[micaeljtoliveira]

The instantiation of the parser could be a module-level fixture.

[manodeep]

Yes, I didn't do it because it would make the test function calls quite long (mostly from my ridiculously long data fixture names), and then I am afraid to see what black would do to such long lines.

Still, I will give that parser-fixture a shot and see what the resulting code looks like

[manodeep]

@micaeljtoliveira Done!

[manodeep]

I am going to make this PR a draft - there are (edit: can't make the PR a draft since it's already approved, probably) make a couple of more things I would like to add:

• missing function docstrings
• Update regex to match all extraneous columns after matching the expected columns - i) this would make the code a bit more symmetric (arbitrary number of initial integer columns are ignored), and ii) potentially allow for parsing a bigger mix of UM versions

[manodeep]

@micaeljtoliveira I am done with my changes. Could not get the "ignore-columns-at-the-end" parsing feature to work - so I have left as is.

[micaeljtoliveira]

@manodeep Just approved. Make sure you squash and merge or, alternatively, clean-up the git history before merging.

[manodeep]

@micaeljtoliveira Thanks! I cleaned up the commits - so should be good to go with a merge commit now.

For reference, the GH UI would only let me squash+merge or rebase+merge if I clicked the "bypass branch protection" checkbox.

[manodeep]

I will merge once the CI passes fully.

[micaeljtoliveira]

For reference, the GH UI would only let me squash+merge or rebase+merge if I clicked the "bypass branch protection" checkbox.

Ah, right, I must have disabled those in the branch protection rules. Sorry ;)