-
Notifications
You must be signed in to change notification settings - Fork 19
Add warning for spack-packages version compatibility #1064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
Added a warning about version compatibility for spack-packages.
|
|
I could put a similar warning in the Create Prereleases and Releases for an ACCESS Model page. Necessary? |
atteggiani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aidanheerdegen for this PR.
There's a minor rendering issue I left a suggestion for.
In the same comment there is another point that might be relevant.
| !!! warning | ||
| It is important that the version of [`access-nri/spack-packages`](https://github.com/ACCESS-NRI/spack-packages) is compatible with the environment. | ||
| If there are concretization errors try checking this. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation problem.
| !!! warning | |
| It is important that the version of [`access-nri/spack-packages`](https://github.com/ACCESS-NRI/spack-packages) is compatible with the environment. | |
| If there are concretization errors try checking this. | |
| !!! warning | |
| It is important that the version of [`access-nri/spack-packages`](https://github.com/ACCESS-NRI/spack-packages) is compatible with the environment. If there are concretization errors try checking this. |
What does "compatible" mean in this case? How would a user check that the spack-packages version is compatible with the spack environment?
Instead of saying "... try checking this", could we quickly describe how a user would check for such compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "compatible" mean in this case? How would a user check that the spack-packages version is compatible with the spack environment?
I was deliberately vague because there is no easy answer to your question. They might need to use the most recent version because then they get all the most recent spack package changes.
Or they might need to use an older version, because they need to remain consistent with the spack packages at an earlier time. There can be inter-dependency between the packages, where changes have to be made in sync so they are consistent.
Perhaps this is the right time to ask @anton-seaice if he had any specific use-cases in mind.
Instead of saying "... try checking this", could we quickly describe how a user would check for such compatibility?
I think the docs already cover where the spack packages version is set. Would it be sufficient to refer to that with a "see above" type direction? Other than that, to know what the "correct" version is depends on what they're trying to do. If it is to be consistent with a released version, then they should use what that environment did. If they're developing something new, then who knows? It would require some careful inspection of package recipes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this is the right time to ask @anton-seaice if he had any specific use-cases in mind.
The main thing folks get stuck on is:
- they clone spack-packages latest from main
- checkout spack.yaml environment file from a deployment repo
and then find it doesn't concretise/build, becuase spack-packages has had a breaking change since the model was last deployed
Possibly if we are very careful with version dependencies going forward this won't continue to be a problem
I believe you added the warning in the "Create Prereleases and Releases for an ACCESS Model" page you mention. |
Almost certainly! :) Thanks for translating my confusing comment. |
|
I think this content is most relevant for this page |
Except that page isn't where the instructions to clone |
Are you suggesting changing the docs to say "clone spack-packages from a specific tag" ? Building from source is when the problem comes up |
Yeah. but I couldn't see a good place to put it. I took another look and decided to try putting it in the part where the concretization is done in this commit: 4b54fe5 Can you take a look and see if that covers the use case you wanted? |
254ca6a to
963790e
Compare
|
FYI, This issue may disappear once we move to Spack v1.1 because it allows Spack to mange |
@harshula |
|
Hi @CodeGat , Do you think you'll go down the path of putting |
|
I think not. Seems there would be a bit of double up with |
@harshula |
anton-seaice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - review was pending from a month ago !
| spack concretize -f --fresh | ||
| ``` | ||
|
|
||
| The version of [`access-nri/access-spack-packages`](https://github.com/ACCESS-NRI/access-spack-packages) must be compatible with the environment. If there are concretization errors try checking the version you cloned is the same as the version used in the deployment repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| The version of [`access-nri/access-spack-packages`](https://github.com/ACCESS-NRI/access-spack-packages) must be compatible with the environment. If there are concretization errors try checking the version you cloned is the same as the version used in the deployment repository. | |
| !!! warning | |
| The version of [`access-nri/access-spack-packages`](https://github.com/ACCESS-NRI/access-spack-packages) must be compatible with the environment. If there are concretization errors try checking the version you cloned is the same as the version used in the deployment repository. |
Should this be a seperate warning? Its not very clear having two warnings in the same box
Can we be more explicit? How do i check the version ?
ACCESS-Hive Docs
Description
Added a warning about version compatibility for spack-packages.
Fixes #987
Type of change
Please delete options that are not relevant.
Checklist: