Move SPI pins to high-impedance state between operations #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurHeymans
force-pushed
the
LazySpiDevice
branch
2 times, most recently
from
a2db6a6 to
0e620ab
Compare
…board Replace the static `Serprog` struct with a trait-based approach where SPI pins are only configured as outputs during actual SPI operations: - Add `SpiDeviceProvider` trait for on-demand SPI device creation - Add `SpiCsGuard` trait for guards that provide SPI+CS access - Add `LedProvider` trait with blanket impl for any `OutputPin` - Replace `Serprog::run_loop()` with free function `run_loop()` - Store SPI frequency and pass to provider on each acquire Pin cleanup on drop: - Embassy SPI/Output do NOT auto-reset pins to input mode - Each platform implements custom guard with explicit pin reset - RP2040: Set funcsel to NULL and reset pad control - STM32: Use Flex drop to set pins to analog mode This prevents the serprog microcontroller from driving the SPI pins when idle, allowing the target mainboard to boot normally with the programmer attached. 🤖 Generated with [eca](https://eca.dev) Co-Authored-By: eca <[email protected]>
ArthurHeymans
force-pushed
the
LazySpiDevice
branch
from
0e620ab to
d759a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the SPI handling to ensure pins are only configured as outputs during active SPI operations. Between operations, pins are reset to high-impedance (analog/disconnected) state to prevent interference with the target flash chip.
Key changes:
SpiDeviceProviderandSpiCsGuardtraits for on-demand SPI configurationThis ensures the programmer doesn't hold the SPI pins in output state when not actively communicating with the flash chip.