Skip to content

Update 8hobbies/workflows digest to aeea4ef #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renovate merged 1 commit into from
Nov 23, 2025
Merged

Update 8hobbies/workflows digest to aeea4ef #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@

jobs:
lint:
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@6ffa892638c05b08601b32c5baa4bbf9a858b620
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@aeea4ef82ae99732c467d6245294bbed0e0fa426

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 months ago

To fix this issue, we need to add a permissions block specifying the minimum required permissions for the workflow at the root level of .github/workflows/lint.yml. Since the workflow only calls a reusable workflow to lint code (which typically only requires read access to repository contents), we can start with the recommended minimal configuration:

permissions:
  contents: read

This block should be placed directly under the name: key (line 13) but before the on: key (line 15) for clarity and convention.

Suggested changeset 1
.github/workflows/lint.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -11,6 +11,8 @@
 # OF THIS SOFTWARE.
 
 name: Lint
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -11,6 +11,8 @@
# OF THIS SOFTWARE.

name: Lint
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/publish-dry-run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@

jobs:
run:
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@6ffa892638c05b08601b32c5baa4bbf9a858b620
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@aeea4ef82ae99732c467d6245294bbed0e0fa426

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 months ago

To fix the problem, we should add an explicit permissions block at the root of the workflow configuration (top-level, right below name:), which will apply to all jobs (unless they override it). Since this workflow is running a dry-run publish and there are no clues in the provided snippet about any tokens requiring special privileges, the safest general default is permissions: contents: read. This will allow the workflow to clone/fetch code, but not to push code, create releases, or do anything with escalated privileges. If, after further inspection, more permissions (such as packages: write) are needed, they can be added later; but starting with the most restrictive set is safest.

To implement this, insert the following code after the name: declaration:

permissions:
  contents: read

This should occur right above the on: block, e.g., on line 14 or 15.

Suggested changeset 1
.github/workflows/publish-dry-run.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/publish-dry-run.yml b/.github/workflows/publish-dry-run.yml
--- a/.github/workflows/publish-dry-run.yml
+++ b/.github/workflows/publish-dry-run.yml
@@ -11,6 +11,8 @@
 # OF THIS SOFTWARE.
 
 name: Publish Dry Run
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -11,6 +11,8 @@
# OF THIS SOFTWARE.

name: Publish Dry Run
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
tags: ["v*"]
jobs:
build:
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@6ffa892638c05b08601b32c5baa4bbf9a858b620
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@aeea4ef82ae99732c467d6245294bbed0e0fa426
secrets:
npm-auth-token: ${{ secrets.NPM_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@

jobs:
test:
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@6ffa892638c05b08601b32c5baa4bbf9a858b620
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@aeea4ef82ae99732c467d6245294bbed0e0fa426

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 3 months ago

To fix this problem, add a permissions: block to the workflow, so that jobs triggered by this workflow do not inherit broad default permissions. The block should be placed at the root level (between name:/on: and jobs:), unless individual jobs require tailored permissions (in which case those jobs would declare them explicitly). As a starting point, set contents: read, which is the recommended minimal permission for most workflows. If a job requires more (such as pull-requests: write), add only those specific permissions. In this case, as the job is simply using a reusable workflow and there is no evidence of a need for write permissions, set contents: read at the root level in .github/workflows/runtime.yml, after the name: and before the on: section.

Suggested changeset 1
.github/workflows/runtime.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/runtime.yml b/.github/workflows/runtime.yml
--- a/.github/workflows/runtime.yml
+++ b/.github/workflows/runtime.yml
@@ -12,6 +12,9 @@
 
 name: Runtime
 
+permissions:
+  contents: read
+
 on:
   push:
     branches: ["master"]
EOF
@@ -12,6 +12,9 @@

name: Runtime

permissions:
contents: read

on:
push:
branches: ["master"]
Copilot is powered by AI and may make mistakes. Always verify output.